Runtime dependency #311
Merged
Runtime dependency #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 6, 2015 16:13
…auses breakage in latest dnx builds (beta6 nightlies)
|
So, it turns out I was wrong about where the breakage I was experiencing was coming from. This change is still valid IMO, but turned out to not be the culprit (what did turn out to be the culprit was a stale |
|
Thanks Ben; sorry for delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
System.Runtimepackage shouldn't be necessary for any of the full-framework TFMs, and the dependency on a now-outdated beta6 build causes breakage on latest beta6 nightlies. Alternatively, if there is some obscure thing happening that made this necessary that I'm not aware of, I'd recommend a floating dependency ("-*").