-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transip provider #1196
Transip provider #1196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great so far! Very clean code, by the way!
I just had a few minor suggestions.
Please remember when you are done to make sure all documentation is up to date (Step 8) and that you've checked your work (Step 13). https://stackexchange.github.io/dnscontrol/writing-providers
Thank you for contributing to the DNSControl project!
Hi Thanks! Allot of code was copied from other providers, so I can't take all credit on that part. I do need to test it before continue-ing. But most of the code should be fine. |
This should be ready to go. |
Please rebase |
Done |
Co-authored-by: Sven Luijten <11269635+svenluijten@users.noreply.github.com>
Thanks for adding a new provider to the project! I'm always excited to see the project grow this way! |
Add functionality to use TransIP DNS