Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transip provider #1196

Merged
merged 8 commits into from
Jul 7, 2021
Merged

Transip provider #1196

merged 8 commits into from
Jul 7, 2021

Conversation

blackshadev
Copy link
Contributor

@blackshadev blackshadev commented Jul 2, 2021

Add functionality to use TransIP DNS

  • GetNameservers
  • GetZoneRecords
  • GetDomainCorrections
  • Added docs
  • Test if it works

Copy link
Contributor

@tlimoncelli tlimoncelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far! Very clean code, by the way!

I just had a few minor suggestions.

Please remember when you are done to make sure all documentation is up to date (Step 8) and that you've checked your work (Step 13). https://stackexchange.github.io/dnscontrol/writing-providers

Thank you for contributing to the DNSControl project!

providers/transip/transipProvider.go Show resolved Hide resolved
providers/transip/transipProvider.go Show resolved Hide resolved
providers/transip/transipProvider.go Outdated Show resolved Hide resolved
@blackshadev
Copy link
Contributor Author

Looking great so far! Very clean code, by the way!

I just had a few minor suggestions.

Please remember when you are done to make sure all documentation is up to date (Step 8) and that you've checked your work (Step 13). https://stackexchange.github.io/dnscontrol/writing-providers

Thank you for contributing to the DNSControl project!

Hi Thanks! Allot of code was copied from other providers, so I can't take all credit on that part.

I do need to test it before continue-ing. But most of the code should be fine.

@blackshadev blackshadev marked this pull request as ready for review July 3, 2021 13:37
@blackshadev
Copy link
Contributor Author

This should be ready to go.

@tlimoncelli
Copy link
Contributor

Please rebase

@blackshadev
Copy link
Contributor Author

Please rebase

Done

Co-authored-by: Sven Luijten <11269635+svenluijten@users.noreply.github.com>
@tlimoncelli
Copy link
Contributor

Thanks for adding a new provider to the project! I'm always excited to see the project grow this way!

@tlimoncelli tlimoncelli merged commit 506b6cc into StackExchange:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants