deSEC implement pagination #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlimoncelli
reviewed
Jul 12, 2021
tlimoncelli
approved these changes
Jul 12, 2021
|
It can be merged |
This was referenced Jul 15, 2021
|
Thanks for fixing this! Big sites really appreciate it! |
tlimoncelli
added a commit
that referenced
this pull request
Jul 21, 2021
* deSEC: Implement pagination for domain list #1177 * deSEC: add debug logging for pagination * deSEC: simplify get/post methods by allowing url / api endpoints as target * deSEC: implement pagination for getRecords function * deSEC: fix linter warnings * deSEC: replace domainIndexInitalized variable with checking if the domainIndex == nil * deSEC: add mutex for domainIndex Co-authored-by: Tom Limoncelli <tlimoncelli@stackoverflow.com>
tlimoncelli
added a commit
that referenced
this pull request
Jul 21, 2021
* Add PrivateKey authentication for TransIP * Remove space before comma * Re-enable CodeQL for Javascript (#1209) * Create codeql-config.yml * Update codeql-analysis.yml Add config to exclude certain files * deSEC implement pagination (#1208) * deSEC: Implement pagination for domain list #1177 * deSEC: add debug logging for pagination * deSEC: simplify get/post methods by allowing url / api endpoints as target * deSEC: implement pagination for getRecords function * deSEC: fix linter warnings * deSEC: replace domainIndexInitalized variable with checking if the domainIndex == nil * deSEC: add mutex for domainIndex Co-authored-by: Tom Limoncelli <tlimoncelli@stackoverflow.com> Co-authored-by: Vincent Hagen <vinnie@script4web.nl> Co-authored-by: Jauder Ho <jauderho@users.noreply.github.com> Co-authored-by: Georg <georg@neuland.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will implement pagination for the deSEC provider (#1177), this is needed when ever the api could return over 500 elements.