Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: add dhcid RR docs #2715

Merged
merged 4 commits into from Dec 11, 2023
Merged

Conversation

fritterhoff
Copy link
Contributor

Fixes #2695

@cafferata
Copy link
Collaborator

Thank you for this work! Can you also update the dnscontrol.d.ts? You can do this by running go generate ./....

@fritterhoff
Copy link
Contributor Author

Done

@cafferata
Copy link
Collaborator

Thank you @fritterhoff. I see there is one more change needed:

SUMAMRY.md

    * [CAA_BUILDER](functions/domain/CAA_BUILDER.md)
    * [CNAME](functions/domain/CNAME.md)
+   * [DHCID](functions/domain/DHCID.md)
    * [DISABLE_IGNORE_SAFETY_CHECK](functions/domain/DISABLE_IGNORE_SAFETY_CHECK.md)
    * [DMARC_BUILDER](functions/domain/DMARC_BUILDER.md)
    * [DS](functions/domain/DS.md)
    * ```

@fritterhoff
Copy link
Contributor Author

Also done ;-)

@cafferata
Copy link
Collaborator

Thank you @fritterhoff. See the online result here: 🚀
https://docs.dnscontrol.org/~/revisions/F27KYc5cDmhwljNT9zNF/language-reference/domain-modifiers/dhcid

@tlimoncelli
Copy link
Contributor

Awesome! Thanks for following up on all this!

@tlimoncelli tlimoncelli merged commit a5a1fac into StackExchange:master Dec 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOCS: Missing DHCID DNS resource type
3 participants