FEATURE: CAA_BUILDER: add issue_critical and issuewild_critical
#2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @llange. See the GitBook preview deep link URL here: Would you mind including |
llange
force-pushed
the
caa_builder_flags
branch
from
327070f
to
bfb0d17
Compare
It is my understanding that - according to https://datatracker.ietf.org/doc/html/rfc8659 - the critical flag can be applied to whatever tag of a CAA record. This change of CAA_BUILDER adds the ability to provide this flag for the `issue` and `issuewild` tags by setting respectively `issue_critical` and `issuewild_critical` to `true`.
llange
force-pushed
the
caa_builder_flags
branch
from
bfb0d17
to
de8f1e6
Compare
|
Hi @cafferata, thanks for your suggestion. I thus updated the doc and tweaked it a little:
Let me know if it's too much or OK. |
|
PS. @tlimoncelli will also do a review and take care of the merge. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is my understanding that - according to https://datatracker.ietf.org/doc/html/rfc8659 -
the critical flag can be applied to whatever tag of a CAA record.
This change of CAA_BUILDER adds the ability to provide this flag for the
issueandissuewildtags by setting respectivelyissue_criticalandissuewild_criticaltotrue.