Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POWERDNS: Value in test was too long #2916

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

fuero
Copy link
Contributor

@fuero fuero commented Apr 19, 2024

Sorry @tlimoncelli - shouldn't have relied on just it being valid base64, there's a max length too.

@tlimoncelli
Copy link
Contributor

Perfect! Thanks!

$ go test -v -verbose -provider POWERDNS -start 43 -end 43
=== RUN   TestDNSProviders
=== RUN   TestDNSProviders/dnscontrol-example.com
=== RUN   TestDNSProviders/dnscontrol-example.com/Clean_Slate:Empty
    integration_test.go:236: 
        - DELETE dnscontrol-example.com NS ns1.example.com. ttl=300
        - DELETE dnscontrol-example.com NS ns2.example.com. ttl=300
=== RUN   TestDNSProviders/dnscontrol-example.com/43:DHCID:Create_DHCID_record
    integration_test.go:236: 
        + CREATE test.dnscontrol-example.com DHCID AAIBY2/AuCccgoJbsaxcQc9TUapptP69lOjxfNuVAA2kjEA= ttl=300
=== RUN   TestDNSProviders/dnscontrol-example.com/43:DHCID:Modify_DHCID_record
    integration_test.go:236: 
        ± MODIFY test.dnscontrol-example.com DHCID (AAIBY2/AuCccgoJbsaxcQc9TUapptP69lOjxfNuVAA2kjEA= ttl=300) -> (AAAAAAAAuCccgoJbsaxcQc9TUapptP69lOjxfNuVAA2kjEA= ttl=300)
--- PASS: TestDNSProviders (1.93s)
    --- PASS: TestDNSProviders/dnscontrol-example.com (1.93s)
        --- PASS: TestDNSProviders/dnscontrol-example.com/Clean_Slate:Empty (0.63s)
        --- PASS: TestDNSProviders/dnscontrol-example.com/43:DHCID:Create_DHCID_record (0.65s)
        --- PASS: TestDNSProviders/dnscontrol-example.com/43:DHCID:Modify_DHCID_record (0.64s)
=== RUN   TestDualProviders
    integration_test.go:358: Clearing everything
    integration_test.go:352: #1:
        - DELETE test.dnscontrol-example.com DHCID AAAAAAAAuCccgoJbsaxcQc9TUapptP69lOjxfNuVAA2kjEA= ttl=300
    integration_test.go:365: Adding nameservers from another provider
    integration_test.go:352: #1:
        + CREATE dnscontrol-example.com NS ns1.example.com. ttl=300
        + CREATE dnscontrol-example.com NS ns2.example.com. ttl=300
    integration_test.go:368: Running again to ensure stability
--- PASS: TestDualProviders (1.03s)
=== RUN   TestNameserverDots
=== RUN   TestNameserverDots/No_trailing_dot_in_nameserver
--- PASS: TestNameserverDots (0.01s)
    --- PASS: TestNameserverDots/No_trailing_dot_in_nameserver (0.00s)
PASS
ok  	github.com/StackExchange/dnscontrol/v4/integrationTest	3.636s

@tlimoncelli tlimoncelli merged commit da6f621 into StackExchange:main Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants