Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NS1: enable concurrency #2952

Merged
merged 2 commits into from
May 13, 2024
Merged

NS1: enable concurrency #2952

merged 2 commits into from
May 13, 2024

Conversation

costasd
Copy link
Contributor

@costasd costasd commented May 13, 2024

This changeset enables optional concurrency for NS1.

Tests:

  1. Compilation with -race (go build -v -race .)
  2. integration tests with -race (go test -v -provider NS1 -race)
  3. dnscontrol ppreview --providers ns1 --full --cmode=all
  4. dnscontrol ppreview --providers ns1 --full --cmode=all

@tlimoncelli
Copy link
Contributor

Yay! One more concurrent provider!

@tlimoncelli tlimoncelli merged commit 734a55c into StackExchange:main May 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@costasd @tlimoncelli