Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't convert local variable references in dict.where(), dict.select(), and dict.selectMany() for YAQL expressions #29

Open
blag opened this issue May 22, 2020 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@blag
Copy link
Contributor

blag commented May 22, 2020

In YAQL expressions, the dict.where(), dict.select(), and dict.selectMany() methods accept a selector predicate, where the input to the predicate is $, and global variable references are not allowed in those predicates (you have to use let() to assign them to other variables). This means that any references aren't global context variable references and should not be converted to ctx() automatically.

We do a lot of "parsing" with regular expressions, so this might not be 100% possible, but it would be nice to see if we can avoid converting $ that shouldn't be converted.

@blag blag added enhancement New feature or request help wanted Extra attention is needed labels May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant