Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ActionChain conversions #3

Open
nmaludy opened this issue Sep 10, 2018 · 1 comment
Open

Support ActionChain conversions #3

nmaludy opened this issue Sep 10, 2018 · 1 comment

Comments

@nmaludy
Copy link
Member

nmaludy commented Sep 10, 2018

Currently only Mistral workflows are supported for conversion.

It should be easy enough to convert ActionChains as well.

We will need some flag on the CLI to say "this is a workflow of type X" so we know what converter to use. Alternatively, we could try to parse both Mistral and ActionChain and use whatever one validates properly.

@blag
Copy link
Contributor

blag commented Jan 28, 2019

We will need some flag on the CLI to say "this is a workflow of type X" so we know what converter to use.

The pack converter script should be able to trust the action metadata, which identifies the type of workflow.

Alternatively, we could try to parse both Mistral and ActionChain and use whatever one validates properly.

This seems incredibly dirty, but I can't imagine AC workflows validating as Mistral workflows or vice versa, so this might work.

I think the converter script should have a flag to tell it which type of validator to use, and fall back to the implicit inference-via-successful-validation method if a flag isn't passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants