Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret action field show as plaint text in rule view #4784

Closed
igorfernandes opened this issue Aug 30, 2019 · 1 comment
Closed

Secret action field show as plaint text in rule view #4784

igorfernandes opened this issue Aug 30, 2019 · 1 comment
Labels
bug security

Comments

@igorfernandes
Copy link

SUMMARY

Secret fields are showing as plain text when we see rule information.

STACKSTORM VERSION

st2 3.1.0, on Python 2.7.5

OS, environment, install method

OS: Oracle Linux 7.5
Custom HA installation with ST2 RPM without changes. All services separate as a single VM.
st2.conf with mask_secrets = True

Steps to reproduce the problem

Create a RULE with HTTP ACTION and set the password field with anything. When click to see RULE details you can see the password as plain text.

Expected Results

As a secret parameter of action, that does not need to show in rule information

Actual Results

We can see all secret field as plain text

Screen Shot 2019-08-30 at 3 46 24 PM
@jeansfelix jeansfelix mentioned this issue Sep 12, 2019
Closed
@igorfernandes
Copy link
Author

Closed by #4807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added mask of rule action secret parameters pepeproject/st2
2 participants
@arm4b @igorfernandes