Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI shows secrets in plain text on Rules/Enforcements section #4802

Open
nicholasamorim opened this issue Oct 17, 2019 · 0 comments
Open

Comments

@nicholasamorim
Copy link
Contributor

SUMMARY

Web UI shows variables marked as secret: true in plain text on Rules/Enforcements.

st2 CLI correctly masks it.

STACKSTORM VERSION

st2 3.1.0 running on Python 2.7

OS, environment, install method

Docker

Steps to reproduce the problem

---
name: full_backup
pack: mongodb
enabled: true
description: Performs a backup of MongoDB
runner_type: orquesta
entry_point: workflows/full_backup.yaml
parameters:
  mongodb_password:
    default: "{{ st2kv.system.mongodb_admin_password | decrypt_kv }}"
    type: string
    secret: true
version: 1.0
description: A workflow that backs up Mongo
input:
  - mongodb_password
vars:
  - stdout: null
  - stderr: null

tasks:
  run_backup_playbook:
    action: core.noop
output:
  - stdout: <% ctx(stdout) %>

Expected Results

For the Web UI to mask the password. But it shows on Web UI shows the password in Rules/Enforcements tab.

Using the st2 CLI execution get correctly masks the secrets.

Actual Results

Web UI shows the password in Rules/Enforcements tab. Open an execution and the password is shown in ACTION INPUT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants