Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering machanism #45

Closed
fabxc opened this issue Aug 17, 2018 · 1 comment
Closed

Add filtering machanism #45

fabxc opened this issue Aug 17, 2018 · 1 comment

Comments

@fabxc
Copy link
Contributor

fabxc commented Aug 17, 2018

We know of users of the existing integration that filter collected metrics for cost control.
The GA version should allow for the same kind of controls. Users could filter the data stored by the main Prometheus server but mutating their existing setup is not a good experience in this case.

The simplest approach is probably a repeated flag that allows to set Prometheus-style label matchers, which must all pass, e.g.

./stackdriver-prometheus-sidecar \
    --filter='job="kubelet"' \
    --filter='__name__!~="cadvisor.*"' \
    ...
@fabxc fabxc closed this as completed Aug 21, 2018
@fabxc
Copy link
Contributor Author

fabxc commented Aug 21, 2018

Fixed via #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant