Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging Updates to Single Sig wallet only with Tor by Default #37

Merged
merged 186 commits into from May 27, 2022
Merged

Merging Updates to Single Sig wallet only with Tor by Default #37

merged 186 commits into from May 27, 2022

Conversation

i5hi
Copy link
Contributor

@i5hi i5hi commented May 27, 2022

v 0.0.10 corrects various minor bugs and strips down the app into only a single signature descriptor wallet with the ability to recover and create new signers or watchers.

It also now uses tor by default and as a result android only until libstackmate provides a cross compatible tor daemon.

Other feature additions include:

  • incognito mode
  • sats/btc unit selector (still needs to update in TransactionItemDetail popup)
  • Global PSBT broadcaster
  • Ability for Watcher wallets to build a PSBT for an external signer.

Some known bugs:

  • Buttons can be janky and unresponsive in certain sections like Wallet recovery and SEND.
  • A particular case was found where change was not being picked up by the wallet. This is an issue with libstackmate.
    TESTERS should always verify balances and history after a TX to see if this bug appears again.
  • Since we use bdk's memory database, sync happens before every api that requires a network call i.e. balance, history and build.
  • Fee estimator is very naive (allows fall back into user set rates)

i5hi and others added 30 commits April 29, 2022 18:45
@i5hi
Created first test file boiler plate.
31dea18 
Initialized cubit with locator. Help needed.
@yshwanth
ui updates
65f9465
@yshwanth
font and display amounts resolved
284ced5
@i5hi
Updated calculator test init state
ee8e8f3
@yshwanth
few changes
e36150c
@i5hi
Updated calculator test init state
1b891ad
@i5hi
Send button does not trigger sendClicked if sendingTx is true.
b8bae13
@i5hi
header padding 12
dce1e6a
@i5hi
WORKING new fee model
00d5584
@i5hi
Added missing files
607674b
@i5hi
updated fee cubit
31db482
@yshwanth
disabled acc no and few changes
301d1ee
@i5hi
Merge branch 'dev' into cubit-test
25cffa7
@i5hi
Updated stackmate core to return R types for better error handling. A…
ddae424 
…dded tests.
@i5hi
Updated test name
960a67b
@i5hi
Updated deriveHardened to use accountNUmber from state
6333b0f
@i5hi
Complete test suite for api/stackmate-core.
0812ae9
@i5hi
Removed test from packages. All tests in master test folder.
eaacc04
@i5hi
Added breaking cubit fees test.
6fe838b
@i5hi
Added breaking node cubit test.
b7eee1f
@i5hi
Made raw strings consts in seed-generate.
a6cba82
@i5hi
Removed incorrect passphrase check/
69eda34
@i5hi
Updated all new-wallet/common files to use const over raw strings.
4f687ca
@i5hi
Updated all new-wallet files to use const over raw strings.
902559a
@i5hi
Updated all cubit/wallet to use const over raw strings.
ecf1761
@i5hi
Removed reddit from project.
587ff3b
@i5hi
Updated packages/bitcoin to return only strings
bed2a8c
@i5hi
Added replacement of , in send::_checkAmount to finally use amount wi…
068b306 
…thout format
@i5hi
Removed rearrange wallet feature.
6143052
@i5hi
Updated stackmate core to return R types for better error handling. A…
cfdd3bb 
…dded tests.

Updated test name

Updated deriveHardened to use accountNUmber from state

Complete test suite for api/stackmate-core.

Removed test from packages. All tests in master test folder.

Added breaking cubit fees test.

Added breaking node cubit test.
i5hi added 21 commits May 22, 2022 05:50
@i5hi
toLowerCase addressChange to support pasting uppercase address
366268c
@i5hi
toLowerCase address in cubits instead of UI
2c5dac8
@i5hi
toLowerCase address in cubits instead of UI
29332cd
@i5hi
Added space to sats unit for Medium Display
41262db
@i5hi
Fixed Home page alignments.
9295186
@i5hi
Fixed Back button issue with small clickable area.
e358602
@i5hi
Fixed Delete wallet text style on button
079337e
@i5hi
Updated Iunderstand in SeedImport to use GesturableArea instead of te…
f83580d 
…xt button
@i5hi
Updated tor to block wallet use until loaded.
06c013c
@i5hi
Cleared linting errors
f207684
@i5hi
Not allowing GetFees without Tor connected.
5f18534
@i5hi
Fixed logger of get fees
6a8b3ac
@i5hi
Updated logo asset and changed project id
cbaa543
@i5hi
Updated logo and app name.
f8ecd4d
@i5hi
Updated logo in android folders.
aa04de5
@i5hi
Added privacy policy
ceaa714
@i5hi
Made slow fee fixed at 1.0 sats/byte
37dd659
@i5hi
Added portrait screen lock.
c5c65e7
@i5hi
Updated logo and removed calculator.
13399b9
@i5hi
Removed coincap remains.
f7bad23
@i5hi
Bumped to v0.0.10 Single sig wallet only with tor by default.
73a4a1c
@i5hi i5hi requested review from mocodesmo and yshwanth May 27, 2022 11:38
@i5hi i5hi added enhancement New feature or request frontend labels May 27, 2022
@i5hi
Copy link
Contributor Author

i5hi commented May 27, 2022

Also added a basic test directory which currently fails since we have made several changes to the cubits. This provides a starting point to adopt TDD moving forward. Module priority for testing should be:

  1. pkg
  2. models
  3. cubits
  4. ui
  5. integration

yshwanth
yshwanth reviewed May 27, 2022
View reviewed changes
Copy link
Contributor

@yshwanth yshwanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main features have been updated,ready to be merged to main branch

@i5hi
Copy link
Contributor Author

i5hi commented May 27, 2022

Main features have been updated,ready to be merged to main branch

Thanks for helping with this update. Merging.

@i5hi i5hi merged commit bf33f3b into master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshwanth yshwanth yshwanth left review comments

@mocodesmo mocodesmo Awaiting requested review from mocodesmo

Assignees

@yshwanth yshwanth

Labels
enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@i5hi @yshwanth