Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Withdrawals are broken on https://bridge.stx.eco/withdraw?net=testnet #187

Closed
netrome opened this issue Jul 17, 2023 · 6 comments
Closed

Comments

@netrome
Copy link
Collaborator

netrome commented Jul 17, 2023

When trying to sign a withdrawal PSBT I'm getting the following error: Uncaught (in promise) TypeError: piTx.addressInfo is undefined

image

@radicleart
Copy link
Collaborator

radicleart commented Jul 17, 2023

@netrome thanks for reporting. I just restarted the node application and tested a withdrawal which sent this transaction

I think the issue is a bug in my deployment pipeline - have raised environment variables on the target machine not overriding the environment from the deployer machine

I'll close this in favour of this more specific issue but please feel free to re-open this if you continue to have problems with withdrawing - I think the manual restart of the server should mean its good for now.

@netrome
Copy link
Collaborator Author

netrome commented Jul 17, 2023

Weird. Something is still not working. I can sign the transactions, but they don't end up being broadcasted. The only warning I'm getting in the UI is Empty string passed to getElementById()

@netrome
Copy link
Collaborator Author

netrome commented Jul 17, 2023

@radicleart I'm not authorized to re-open this issue, but I'd love to get some help understanding why my transaction is not broadcasted.

@radicleart radicleart reopened this Jul 17, 2023
@radicleart
Copy link
Collaborator

Reopening to investigate broadcast issue

@netrome
Copy link
Collaborator Author

netrome commented Jul 17, 2023

Reopening to investigate broadcast issue

Thank you!

@radicleart
Copy link
Collaborator

@netrome - summary of the changes here..

  1. Improved the fee calculation routine this.fee = Math.floor(vsize * feeRate / 1024);
  2. Now uses tx.extract() after finalisation which performs additional checks picked up and displayed before broadcast
  3. The UI attempts to broadcast via Block cypher if that fails it send the tx to the API which attempts to broadcast via Bitcoin Core node and then via mempool.
  4. Fixed a secondary bug which built data for op_return as if for op_drop.

Will leave this open for now in case other issues turn up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants