Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨✨ SELKS iso #455

Closed
1 task done
Acenl12 opened this issue Nov 17, 2023 · 3 comments
Closed
1 task done

✨✨ SELKS iso #455

Acenl12 opened this issue Nov 17, 2023 · 3 comments

Comments

@Acenl12
Copy link

Acenl12 commented Nov 17, 2023

Is there an existing feature request that has already been created?

  • I have searched the exiting features requests

Is your feature request related to a problem? Please describe.

What I noticed is that when everything is installed you go to the main page there is no http to https redirect, so I changed it for myself. Maybe that's also useful for implementing in the ISO. I wanted to do a pull request on the ISO, but i dont see the contents anywhere in your repo. I just added this to the nginx of the server (not in the nginx container)

server {
    listen 80 default_server;

    server_name _;

    return 301 https://$host$request_uri;
}

Describe the solution you would like?

.What I noticed is that when everything is installed you go to the main page there is no http to https redirect, so I changed it for myself. Maybe that's also useful for implementing in the ISO. I wanted to do a pull request on the ISO, but i dont see the contents anywhere in your repo. I just added this to the nginx of the server (not in the nginx container)

server {
   listen 80 default_server;

   server_name _;

   return 301 https://$host$request_uri;
}

Of course remove the listen 80 from the server block that was initial there

Alternative Solutions

No response

Additional Context

No response

@pevma
Copy link
Member

pevma commented Nov 20, 2023

Thanks @Acenl12 for the report and fix!
One place to include this is maybe in the host prep script - https://github.com/StamusNetworks/SELKS/blob/master/staging/config/hooks/live/chroot-inside-Debian-Live.hook.chroot

@Acenl12
Copy link
Author

Acenl12 commented Nov 20, 2023

Thanks @Acenl12 for the report and fix! One place to include this is maybe in the host prep script - https://github.com/StamusNetworks/SELKS/blob/master/staging/config/hooks/live/chroot-inside-Debian-Live.hook.chroot

Are you guys going to change it yourself? Or do you expect a pull request from me?

@Acenl12
Copy link
Author

Acenl12 commented Feb 8, 2024

Close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants