Skip to content
This repository has been archived by the owner on Mar 26, 2020. It is now read-only.

Example code #13

Open
itpmngt opened this issue May 24, 2015 · 3 comments
Open

Example code #13

itpmngt opened this issue May 24, 2015 · 3 comments

Comments

@itpmngt
Copy link

itpmngt commented May 24, 2015

Regarding the example code given in the front page:

this.assert.ok(this.$('.signup-button').length, 'expects button to be in the DOM');

There is no more '.signup-button' at GitHub frontpage, and in case we are logged-in there are no signup available at all

Best,

@StanAngeloff
Copy link
Owner

Ah, thanks for reporting this one as well. I guess GitHub are constantly changing their home page and updating the code will be a game of catching up. How about using the following query instead [href="/join"]?

@itpmngt
Copy link
Author

itpmngt commented May 25, 2015

Personally, I would make an example using Google's webpage instead of GitHub, and there is the scenario when an user is logged-in, there will be no /join I guess...

@StanAngeloff
Copy link
Owner

the scenario when an user is logged-in, there will be no /join I guess...

For the purpose of the example code in the README no cookies or log ins will be present. So the button should always be there... that is unless GitHub overhaul the HTML, of course.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants