fix(Analytics): no tags tracking for upload & crawl #1024

gozineb · 2023-08-22T17:39:29Z

Description

Fix tracking for file_uploaded,url_crawled and invalid_url
Add api for backend requests for upload and crawl
Fix some linter issues

Checklist before requesting a review

Please delete options that are not relevant.

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented hard-to-understand areas
I have ideally added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged

Screenshots (if appropriate):

vercel · 2023-08-22T17:39:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 23, 2023 8:02am
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 23, 2023 8:02am

mamadoudicko · 2023-08-23T06:43:21Z

frontend/app/(auth)/login/hooks/useLogin.ts

@@ -64,7 +64,7 @@ export const useLogin = () => {
        redirect(previousPage);
      }
    }
-  }, [session?.user]);
+  }, [session?.user, track]);


Why ? Since track is a static function

mamadoudicko · 2023-08-23T06:45:26Z

frontend/app/App.tsx


  useEffect(() => {
    void fetchAllBrains();
    void fetchAndSetActiveBrain();
-  }, [session?.user]);
+  }, [fetchAllBrains, fetchAndSetActiveBrain]);


Why? The fetch seems to be required primarily only when the auth status changes, plus these functions are static.

mamadoudicko · 2023-08-23T06:47:41Z

docker-compose.dev.yml

@@ -32,7 +32,7 @@ services:
      context: backend
      dockerfile: Dockerfile
    container_name: backend-core
-    command: uvicorn main:app --host 0.0.0.0 --port 5050
+    command: uvicorn main:app --reload --host 0.0.0.0 --port 5050


mamadoudicko · 2023-08-23T06:56:11Z

...rainManagementTabs/components/SettingsTab/components/PublicPrompts/hooks/usePublicPrompts.ts

@@ -17,7 +17,7 @@ export const usePublicPrompts = ({ onSelect }: UsePublicPromptsProps) => {
      setPublicPrompts(await getPublicPrompts());
    };
    void fetchPublicPrompts();
-  }, []);
+  }, [getPublicPrompts]);


Static function too

mamadoudicko · 2023-08-23T06:57:57Z

frontend/app/upload/components/Crawler/hooks/useCrawler.ts

@@ -1,41 +1,41 @@
-/* eslint-disable */


mamadoudicko · 2023-08-23T07:03:15Z

frontend/app/upload/components/Crawler/hooks/useCrawler.ts

        });
      } finally {
        setCrawling(false);
      }
    },
-    [session.access_token, publish]
+    [publish, crawlWebsiteUrl, t, track]


mamadoudicko · 2023-08-23T07:08:54Z

frontend/app/upload/components/Crawler/index.tsx

-  function Crawler() {
-    return (
+  return (
+    <Suspense fallback={"Loading..."}>


We're not lo longer using server component so we can remove these

frontend/app/upload/components/FileUploader/hooks/useFileUploader.ts

github-actions · 2023-08-23T08:03:11Z

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/upload/components/Crawler/hooks/useCrawler.ts

The useCrawler hook is using the session.access_token as a dependency for the useCallback hook. This might cause unnecessary re-renders if the access_token changes frequently. Consider removing it from the dependency array if it's not necessary for the function to re-run when it changes.

const crawlWebsite = useCallback(
  async (brainId: UUID | undefined) => {
    // function body
  },
  [] // remove session.access_token from dependencies
);

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/upload/components/FileUploader/hooks/useFileUploader.ts

The upload function is using the session.access_token as a dependency for the useCallback hook. This might cause unnecessary re-renders if the access_token changes frequently. Consider removing it from the dependency array if it's not necessary for the function to re-run when it changes.

const upload = useCallback(
  async (file: File, brainId: UUID) => {
    // function body
  },
  [] // remove session.access_token from dependencies
);

Risk Level 3 - /home/runner/work/quivr/quivr/frontend/app/upload/components/Crawler/index.tsx

The component has been stripped of its contents and only empty divs are left. This will result in an empty component being rendered. Ensure that the necessary JSX elements are included.

return (
  <div className=\"w-full\">
    <div className=\"flex justify-center gap-5 px-6\">
      <div className=\"max-w-xl w-full\">
        <div className=\"flex-col justify-center gap-5\">
          // Add necessary JSX elements here
        </div>
      </div>
    </div>
  </div>
);

🔄🔒🚫

Powered by Code Review GPT

* 🚚 create useCrawlApi to use in useCrawler hook * 🚑 fix tracking in Crawl * 🧑‍💻 add hot reloading within docker containers * 🚑 fix tracking for upload * 🚚 create useUploadApi for fileUpload request * 📈 add june tag for Language change * 🩹 revert dependencies

gozineb added 5 commits August 22, 2023 17:47

🚚 create useCrawlApi to use in useCrawler hook

f039461

🚑 fix tracking in Crawl

6ea20f7

🧑‍💻 add hot reloading within docker containers

d460f2a

🚑 fix tracking for upload

eb95280

🚚 create useUploadApi for fileUpload request

c30f9aa

gozineb had a problem deploying to preview August 22, 2023 17:39 — with GitHub Actions Failure

gozineb changed the title ~~Analytics/june debug~~ fix(Analytics): no tags tracking for upload & crawl Aug 22, 2023

vercel bot deployed to Preview – quivrapp August 22, 2023 17:42 View deployment

gozineb had a problem deploying to preview August 22, 2023 17:57 — with GitHub Actions Failure

vercel bot deployed to Preview – quivrapp August 22, 2023 17:58 View deployment

vercel bot deployed to Preview – docs August 22, 2023 17:58 View deployment

mamadoudicko suggested changes Aug 23, 2023

View reviewed changes

gozineb added 2 commits August 23, 2023 09:55

📈 add june tag for Language change

21da60b

🩹 revert dependencies

1ba3902

gozineb force-pushed the analytics/june-debug branch from eb1fda4 to 1ba3902 Compare August 23, 2023 08:00

gozineb temporarily deployed to preview August 23, 2023 08:00 — with GitHub Actions Inactive

vercel bot deployed to Preview – docs August 23, 2023 08:00 View deployment

vercel bot deployed to Preview – quivrapp August 23, 2023 08:02 View deployment

mamadoudicko approved these changes Aug 23, 2023

View reviewed changes

gozineb merged commit 2b74ebc into main Aug 23, 2023
7 checks passed

StanGirard mentioned this pull request Aug 23, 2023

chore(main): release 0.0.61 #1013

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Analytics): no tags tracking for upload & crawl #1024

fix(Analytics): no tags tracking for upload & crawl #1024

gozineb commented Aug 22, 2023

vercel bot commented Aug 22, 2023 •

edited

mamadoudicko Aug 23, 2023

mamadoudicko Aug 23, 2023

mamadoudicko Aug 23, 2023

mamadoudicko Aug 23, 2023

mamadoudicko Aug 23, 2023

mamadoudicko Aug 23, 2023

mamadoudicko Aug 23, 2023

github-actions bot commented Aug 23, 2023

fix(Analytics): no tags tracking for upload & crawl #1024

fix(Analytics): no tags tracking for upload & crawl #1024

Conversation

gozineb commented Aug 22, 2023

Description

Checklist before requesting a review

Screenshots (if appropriate):

vercel bot commented Aug 22, 2023 • edited

mamadoudicko Aug 23, 2023

Choose a reason for hiding this comment

mamadoudicko Aug 23, 2023

Choose a reason for hiding this comment

mamadoudicko Aug 23, 2023

Choose a reason for hiding this comment

mamadoudicko Aug 23, 2023

Choose a reason for hiding this comment

mamadoudicko Aug 23, 2023

Choose a reason for hiding this comment

mamadoudicko Aug 23, 2023

Choose a reason for hiding this comment

mamadoudicko Aug 23, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 23, 2023

Powered by Code Review GPT

vercel bot commented Aug 22, 2023 •

edited