Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chat config modal #807

Merged
merged 4 commits into from
Aug 1, 2023
Merged

feat: add chat config modal #807

merged 4 commits into from
Aug 1, 2023

Conversation

mamadoudicko
Copy link
Contributor

@mamadoudicko mamadoudicko commented Jul 31, 2023

Description

  • Add brain config overwriting from chat config

Related issue: #744

@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 7:41am
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 7:41am

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

LOGAF Level 3 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ChatInput/components/ConfigModal/hooks/useConfigModal.ts

  1. The useEffect hooks could benefit from more comments explaining their purpose.
  2. The handleSubmit function could be improved by adding error handling for when chatId is undefined.

Example:

const handleSubmit = (e: FormEvent) => {
  e.preventDefault();
  if (chatId === undefined) {
    // Handle error
    return;
  }
  ...
};

LOGAF Level 3 - /home/runner/work/quivr/quivr/frontend/lib/components/NavBar/components/NavItems/index.tsx

  1. The NavItems component could be improved by adding a more descriptive fallback for when isUserLoggedIn is false. Currently, it only shows Github and Discord links which might not be informative to the user.
  2. The NavItems component could be improved by adding error handling for when session is undefined.

Example:

if (session === undefined) {
  // Handle error
  return;
}

LOGAF Level 3 - /home/runner/work/quivr/quivr/backend/core/repository/brain_subscription/resend_invitation_email.py

  1. The resend.api_key is being set in the function. This should be set in a configuration file or environment variable.
  2. The resend_invitation_email function is doing too much. Consider separating the email body creation into a separate function.

Example:

resend.api_key = os.getenv('RESEND_API_KEY')

💬🔧🔑


Powered by Code Review GPT

gozineb
gozineb previously approved these changes Aug 1, 2023
@gozineb gozineb merged commit d018ab6 into main Aug 1, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants