feat(backend): implement brain-prompt link

[mamadoudicko]

Description

• Refactor Brains.py (split into Entity, Repo, and Service)
• Add prompt_id to brain table
• Add prompt CRU endpoints

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 3, 2023 8:19am
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 3, 2023 8:19am

[github-actions]

LOGAF Level 2 - /home/runner/work/quivr/quivr/backend/core/routes/upload_routes.py

1. The upload_file function could be improved by separating the file validation and the file processing into separate functions. This would make the code easier to read and maintain.

2. The use of environment variables directly in the code can make it difficult to manage and test. Consider using a configuration management system to handle environment variables.

3. The error messages returned by the function could be more descriptive. For example, instead of just saying 'User's brain will exceed maximum capacity with this upload', it could also include information about the current brain size and the size of the file being uploaded.

Example:

message = {
    "message": f"User's brain will exceed maximum capacity with this upload. Current brain size: {current_brain_size}, file size: {file_size}",
    "type": "error",
}

---

LOGAF Level 3 - /home/runner/work/quivr/quivr/backend/core/models/brains.py

1. The openai_api_key field in the Brain class is a potential security risk. API keys should not be stored in plain text and should not be exposed. Consider using environment variables or a secure vault service to store sensitive information.

2. The get_brain_users and delete_user_from_brain methods are marked as TODO to move to a new BrainService. It's a good practice to separate concerns and make the code more modular. Consider creating a new service class to handle these operations.

3. The create method is using commons as a parameter in the class constructor. This could lead to potential issues if the commons object changes after the Brain object is created. Consider passing commons as a parameter to the methods that need it instead of storing it in the object.

---

LOGAF Level 3 - /home/runner/work/quivr/quivr/backend/core/repository/brain/set_as_default_brain_for_user.py

1. Add type hints to the commons variable.

Example:

commons: Dict[str, Any] = common_dependencies()

2. Add error handling for the case where get_user_default_brain or update operation fails.

---

📂🔒🔧

---

Powered by Code Review GPT

[gozineb]

prompt_id can be null and shpild reference the table prompts' id column

[gozineb]

You would akso need to add the new column in the brains in tables.sql