feat(qa): improve code

[StanGirard]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 7, 2023 5:54pm
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 7, 2023 5:54pm

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/backend/core/llm/qa_base.py

The generate_stream function seems to be doing a lot of things. Consider breaking it down into smaller functions to improve readability and maintainability. For example, the code for creating the answering_llm and doc_chain could be moved to a separate function. Also, the error handling in the wrap_done function could be improved. Instead of logging the error and continuing, it might be better to re-raise the exception after logging it, so that the error can be handled by the caller of generate_stream.

Example:

try:
    await fn
except Exception as e:
    logger.error(f\"Caught exception: {e}\")
    raise
finally:
    event.set()

---

Risk Level 5 - /home/runner/work/quivr/quivr/backend/core/llm/base.py

The openai_api_key and user_openai_api_key are being stored as plain text which is a security risk. Consider using a secure method to store and retrieve sensitive data like API keys. For example, you could use environment variables or a secure vault service.

---

📚🔐🔧

---

Powered by Code Review GPT