Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translations): pr portuguese translations #933

Merged
merged 4 commits into from
Aug 12, 2023

Conversation

gozineb
Copy link
Contributor

@gozineb gozineb commented Aug 11, 2023

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2023 4:52pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2023 4:52pm

@gozineb gozineb temporarily deployed to preview August 11, 2023 11:23 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2023

Risk Level 3 - /home/runner/work/quivr/quivr/backend/core/routes/chat_routes.py

  1. The delete_chat_from_db function is catching all exceptions and simply printing them. This is not a good practice as it can make debugging difficult. Instead, consider logging the exceptions with more context or re-raise them after logging. For example:
try:
    supabase_db.delete_chat_history(chat_id)
except Exception as e:
    logger.error(f'Failed to delete chat history for chat_id {chat_id}: {e}')
    raise
  1. The check_user_limit function is using os.getenv to get the MAX_REQUESTS_NUMBER environment variable. This is not a good practice as it can lead to unexpected behavior if the environment variable is not set. Instead, consider using os.environ which will raise an exception if the environment variable is not set. For example:
max_requests_number = int(os.environ['MAX_REQUESTS_NUMBER'])
  1. The create_question_handler and create_stream_question_handler functions are retrieving the user's OpenAI API key from the request headers. This is a potential security risk as it exposes the API key in the request headers. Consider using a more secure method to transmit the API key, such as using HTTPS and storing the API key in a secure cookie.

🐛🔑🔒


Powered by Code Review GPT

mamadoudicko
mamadoudicko previously approved these changes Aug 11, 2023
@StanGirard StanGirard temporarily deployed to preview August 12, 2023 16:49 — with GitHub Actions Inactive
@StanGirard StanGirard merged commit d80178a into main Aug 12, 2023
7 checks passed
StanGirard added a commit that referenced this pull request Sep 12, 2023
* ✨ add typing to translations

* 🐛 add removed brain key in some languages

* 🐛 put correct translations for fr/es/ru

* fix(translation): missing a few

---------

Co-authored-by: Stan Girard <girard.stanislas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants