feat(onboarding): add suggested questions answer

[mamadoudicko]

Screen.Recording.2023-10-11.at.17.50.15.mp4

#1389

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2023 4:14pm
quivr-strapi	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2023 4:14pm
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2023 4:14pm

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/backend/models/databases/supabase/chats.py

The changes in this file involve the addition of a new method add_question_and_answer to the Chats class. This method inserts a new record into the chat_history table. However, there is a potential issue with error handling. If the insert operation fails for any reason, the method will return None without any indication of what went wrong. Consider raising an exception or returning an error message in case of failure. For example:

if len(response) == 0:
    raise Exception('Failed to add question and answer')

This will make it easier to debug issues in the future.

---

Risk Level 2 - /home/runner/work/quivr/quivr/backend/repository/chat/add_question_and_answer.py

This file introduces a new function add_question_and_answer that calls the method of the same name on a supabase_db object. The function is straightforward and doesn't introduce any apparent bugs or performance issues. However, similar to the previous file, there is a lack of error handling. If the add_question_and_answer method on the supabase_db object fails, the function will return None without any indication of what went wrong. Consider adding error handling as suggested in the previous feedback.

---

Risk Level 3 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/components/ChatInput/components/OnboardingQuestions/components/OnboardingQuestion/hooks/useOnboardingQuestion.ts

1. The useOnboardingQuestion hook has a lot of side effects and state changes. Consider breaking it down into smaller, more manageable hooks.
2. The addQuestionAndAnswerToChat function is defined inside a hook and it's async but it's not being awaited when called inside useEffect. This could lead to unexpected behavior.
3. The handleSuggestionClick function is async but it's not being awaited when called. This could lead to unexpected behavior.

Example code snippet for point 2:

useEffect(() => {
    if (!isDone) {
      return;
    }
    (async () => {
      await addQuestionAndAnswerToChat();
    })();
}, [isDone]);

---

🐛🔧⚠️

---

Powered by Code Review GPT

[gozineb]

Nice, just need to change the logic to create a chat when clicking on one of the messages