feat(toast): add global publisher #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mamadoudicko
force-pushed
the
feat/update-toast-config
branch
from
5736c86
to
8d9b488
Compare
StanGirard
approved these changes
May 27, 2023
adityanandanx
suggested changes
May 27, 2023
Comment on lines
+9
to
+19
| const toggleToast = (value: boolean, index: number) => { | ||
| setToasts((toasts) => | ||
| toasts.map((toast, i) => { | ||
| if (i === index) { | ||
| toast.open = value; | ||
| } | ||
| return toast; | ||
| }) | ||
| ); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Can you update toggleToast function to use the id of the toasts instead of index?
There was a problem hiding this comment.
Oow ! Thanks Man 😄
Fixed it here: #178
StanGirard
pushed a commit
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the toast system by refactoring it and introduces the use of context to incorporate a global notification publisher.
Checklist before requesting a review
Please delete options that are not relevant.
Screenshots (if appropriate):