Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/poplayout warning #194

Merged
merged 6 commits into from
May 29, 2023
Merged

Fix/poplayout warning #194

merged 6 commits into from
May 29, 2023

Conversation

adityanandanx
Copy link
Contributor

Description

Framer motion's AnimatePresence requires to forwardRef to work properly.
This PR forwards ref in FileComponent in /upload and DocumentElement in /explore.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • Any dependent changes have been merged

Screenshots (if appropriate):

quivrPoplayout-.2.mp4

@vercel
Copy link

vercel bot commented May 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quiver ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 4:05am

Copy link
Collaborator

@StanGirard StanGirard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanGirard
Copy link
Collaborator

@mamadoudicko

Copy link
Contributor

@mamadoudicko mamadoudicko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job !

@mamadoudicko mamadoudicko merged commit 3769795 into main May 29, 2023
2 checks passed
StanGirard pushed a commit that referenced this pull request Sep 12, 2023
* fix(auth): use redirect instead of router

* fix(auth): use router for after render redirects

* fix(anims): forward ref in file component

* fix(anims): forward ref in document item

* fix(CI)
@StanGirard StanGirard deleted the fix/poplayout-warning branch January 20, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants