Feat: backend refactor #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gozineb
reviewed
Jun 12, 2023
| print("/chat/{chat_id}",chats) | ||
| return {"chatId": chat_id, "history": chats[0]['history']} | ||
| chats = get_chat_details(commons, chat_id) | ||
| if len(chats) > 0: |
There was a problem hiding this comment.
Great that you added this check !
gozineb
reviewed
Jun 12, 2023
backend/routes/chat_routes.py
Outdated
| @chat_router.put("/chat/{chat_id}", dependencies=[Depends(JWTBearer())]) | ||
| async def chat_endpoint(request: Request,commons: CommonsDep, chat_id: UUID, chat_message: ChatMessage, credentials: dict = Depends(JWTBearer())): | ||
| # helper method for update and create chat | ||
| def chat_handler(request, commons, chat_id, chat_message, credentials, is_new_chat=False): |
gozineb
approved these changes
Jun 12, 2023
gozineb
approved these changes
Jun 12, 2023
bO-05
pushed a commit
to bO-05/quivr
that referenced
this pull request
Jun 13, 2023
* fix: edge cases on migration scripts * chore: remove unused deps. * refactor: user_routes * refactor: chat_routes * refactor: upload_routes * refactor: explore_routes * refactor: crawl_routes * chore(refactor): get current user * refactor: more dead dependencies * bug: wrap email in credentials dict. --------- Co-authored-by: Stan Girard <girard.stanislas@gmail.com>
StanGirard
added a commit
that referenced
this pull request
Sep 12, 2023
* fix: edge cases on migration scripts * chore: remove unused deps. * refactor: user_routes * refactor: chat_routes * refactor: upload_routes * refactor: explore_routes * refactor: crawl_routes * chore(refactor): get current user * refactor: more dead dependencies * bug: wrap email in credentials dict. --------- Co-authored-by: Stan Girard <girard.stanislas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Remove a bunch of unused dependencies
Refactors routes to remove common logic
Create a auth helper function to use FastAPI's inbuilt dependency injection.
Checklist before requesting a review
Please delete options that are not relevant.
Screenshots (if appropriate):