feat: user can create api keys #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mattzcarey
commented
Jun 14, 2023
…ey-with-the-fe-for-quivr' of https://github.com/StanGirard/quivr into 315-api-key-gen-aauser-i-can-create-and-delete-an-api-key-with-the-fe-for-quivr
StanGirard
reviewed
Jun 14, 2023
Comment on lines
20
to
22
| <ConfigForm /> | ||
| <ApiKeyConfig /> | ||
| </section> |
There was a problem hiding this comment.
<ApiKeyConfig /> should maybe go to <ConfirmForm />, just before <UserAccountSection />, since <ModelConfig/> and <BackendConfig /> are already there
|
|
||
| class JWTBearer(HTTPBearer): | ||
| class AuthBearer(HTTPBearer): |
There was a problem hiding this comment.
Nice job! i like this validator logic
backend/auth/auth_bearer.py
Outdated
Comment on lines
34
to
36
| return await get_user_from_api_key(token, commons) | ||
| else: | ||
| raise HTTPException(status_code=402, detail="Invalid token or expired token.") |
There was a problem hiding this comment.
The returned message should maybe be more personalised since "Invalid token or expired token" is not really relevant for api key
Additionally, it would be better to return 401 instead of 402 here. (WDYT @StanGirard ? 402 is the fabulous "Payment Required")
bO-05
pushed a commit
to bO-05/quivr
that referenced
this pull request
Jun 15, 2023
* feat: user can create api keys * fix: linting on build * Update backend/routes/api_key_routes.py * chore: rename and refactor AuthBearer * chore: add types
StanGirard
pushed a commit
that referenced
this pull request
Sep 12, 2023
* feat: user can create api keys * fix: linting on build * Update backend/routes/api_key_routes.py * chore: rename and refactor AuthBearer * chore: add types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Create and use API keys
#315
Checklist before requesting a review
Please delete options that are not relevant.
Screenshots (if appropriate):