Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Reorganization #58

Merged
merged 3 commits into from
Apr 8, 2023
Merged

Module Reorganization #58

merged 3 commits into from
Apr 8, 2023

Conversation

PSchmiedmayer
Copy link
Member

Module Reorganization

♻️ Current situation & Problem

  • All current CardinalKit Modules that are part of the Stanford organization are currently targets in this repo. This makes build times and interdependencies challenging to manage and leads to challenges using individual modules.

💡 Proposed solution

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

@PaulsAutomationBot PaulsAutomationBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖🚀

@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #58 (b12ed98) into main (6162a67) will increase coverage by 9.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   79.57%   89.49%   +9.92%     
==========================================
  Files         129       28     -101     
  Lines        4957      504    -4453     
==========================================
- Hits         3944      451    -3493     
+ Misses       1013       53     -960     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6162a67...b12ed98. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit 35b38a9 into main Apr 8, 2023
7 checks passed
@PSchmiedmayer PSchmiedmayer deleted the moduleSplitup branch April 8, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants