Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tests & Checkout Experience #9

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Conversation

PSchmiedmayer
Copy link
Member

Improve Tests & Checkout Experience

♻️ Current situation & Problem

  • The current tests make a lot of assumptions about the text on-screen in the template application which makes it hard to modify this for the individual use cases.
  • The repository currently uses git lfs to store image files.

💡 Proposed solution

  • This PR improves the UI tests by focusing less on the content and more on the core user flow
  • Moves all files out of LFS storage

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #9 (179711f) into main (343fc1b) will decrease coverage by 9.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              main       #9      +/-   ##
===========================================
- Coverage   100.00%   90.83%   -9.17%     
===========================================
  Files            4       30      +26     
  Lines           78      741     +663     
===========================================
+ Hits            78      673     +595     
- Misses           0       68      +68     
Impacted Files Coverage Δ
...eSharedContext/CodableArray+RawRepresentable.swift 42.86% <0.00%> (ø)
...MockDataStorageProvider/MockUploadDetailView.swift 100.00% <0.00%> (ø)
...Sources/TemplateSharedContext/Binding+Negate.swift 100.00% <0.00%> (ø)
...odules/Sources/TemplateSchedule/ScheduleView.swift 97.27% <0.00%> (ø)
...es/TemplateOnboardingFlow/InterestingModules.swift 100.00% <0.00%> (ø)
...s/Sources/TemplateSharedContext/Bundle+Image.swift 83.34% <0.00%> (ø)
...TemplateOnboardingFlow/AccountSetup/UserView.swift 100.00% <0.00%> (ø)
...lateOnboardingFlow/AccountSetup/AccountSetup.swift 97.71% <0.00%> (ø)
...ources/TemplateOnboardingFlow/OnboardingFlow.swift 91.67% <0.00%> (ø)
...ources/TemplateSchedule/Bundle+Questionnaire.swift 66.67% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 343fc1b...179711f. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit ae5d9a5 into main Feb 16, 2023
@PSchmiedmayer PSchmiedmayer deleted the feature/improveTests branch February 16, 2023 01:30
NikolaiMadlener pushed a commit to NikolaiMadlener/SpeziTemplateApplication that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant