Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0.5: HW protected functions can't be called from OnClick script handlers #62

Closed
Meorawr opened this issue Feb 11, 2021 · 1 comment
Closed
Labels
Acknowledged by Blizzard We received word from Blizzard that this is being tracked internally Bug Something isn't working Mainline This issue affects the current live Retail client ✔️ Verifiable Example A verifiable example has been provided.

Comments

@Meorawr
Copy link
Collaborator

Meorawr commented Feb 11, 2021

As of 9.0.5.37503 it seems that OnClick handlers on buttons aren't considered viable sources of hardware inputs. This breaks things like addons creating buttons to call functions like ReloadUI or SendWho.

The following snippet works fine on 9.0.2.37474 but not on 9.0.5.37503:

B1 = B1 or CreateFrame("Button", nil, UIParent, "UIPanelButtonTemplate");
B1:SetSize(200, 22);
B1:SetPoint("CENTER");
B1:SetText("Click for things");
B1:SetScript("OnClick", function()
      C_FriendList.SetWhoToUi(true);
      C_FriendList.SendWho((UnitName("player")));
end);

If you change the "OnClick" handler to "OnMouseDown", "OnMouseUp", "OnKeyDown", etc. it works fine on 9.0.5.

@Meorawr Meorawr added Bug Something isn't working Mainline PTR This issue affects the Retail PTR client Acknowledged by Blizzard We received word from Blizzard that this is being tracked internally Reported on IRC ✔️ Verifiable Example A verifiable example has been provided. labels Feb 11, 2021
@Meorawr
Copy link
Collaborator Author

Meorawr commented Feb 17, 2021

Fixed in 9.0.5.37623.

@Meorawr Meorawr closed this as completed Feb 17, 2021
@Meorawr Meorawr added Mainline This issue affects the current live Retail client and removed Mainline PTR This issue affects the Retail PTR client labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acknowledged by Blizzard We received word from Blizzard that this is being tracked internally Bug Something isn't working Mainline This issue affects the current live Retail client ✔️ Verifiable Example A verifiable example has been provided.
Projects
None yet
Development

No branches or pull requests

1 participant