Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display registration date, contribution link and gender on usepages; allow citizen-tagline* to be fully parsed #657

Merged
merged 10 commits into from
Jun 8, 2023

Conversation

Dringsim
Copy link
Contributor

@Dringsim Dringsim commented Jun 5, 2023

image

@alistair3149
Copy link
Member

alistair3149 commented Jun 6, 2023

That looks awesome, thanks a ton for making a patch for it :D

For the gender sign, I think it might get complicated when it comes to non-binary genders. It might be more suitable to go for preferred pronouns instead, as it is also how the MediaWiki core preference was referring to:

image

Since there are no such messages in core, we might have to create it ourselves. The end of the message key (e.g. male) refers to the parameter from MW core. The message key is generic as it might be used in other parts of Citizen.

{
    "citizen-pronouns-subjective-male": "He",
    "citizen-pronouns-objective-male": "Him",
    "citizen-pronouns-possessive-male": "His",
    "citizen-pronouns-subjective-female": "She",
    "citizen-pronouns-objective-female": "Her",
    "citizen-pronouns-possessive-female": "Hers",
    "citizen-pronouns-subjective-notknown": "They",
    "citizen-pronouns-objective-notknown": "Them",
    "citizen-pronouns-possessive-notknown": "Theirs"
}

Lastly, would you mind to reorder the items so it goes by gender > edits > registration date? Here's a mockup:
image

@alistair3149 alistair3149 merged commit 25d25e3 into StarCitizenTools:main Jun 8, 2023
4 checks passed
@Dringsim
Copy link
Contributor Author

Dringsim commented Jun 9, 2023

Hmm... many languages don't have pronoun declension. Use {{GENDER:|He|She|They}}?

@Dringsim
Copy link
Contributor Author

Dringsim commented Jun 9, 2023

I perfer gender signs than pronouns in tagline. Though pronouns in bios are familiar to English-speaking users, they may make other users confused - pronouns are rarely used in bios in Chinese-speaking community; I have ever seen many trans persons put English pronouns in their bios while surrounding text is in Chinese (Mandarin). Also, in many languages, pronouns are gender-neutral. {{GENDER:|He|She|They}} in Turkish may be {{GENDER:|o|o|o}}. Users can't guess what it is.

@alistair3149
Copy link
Member

I perfer gender signs than pronouns in tagline. Though pronouns in bios are familiar to English-speaking users, they may make other users confused - pronouns are rarely used in bios in Chinese-speaking community; I have ever seen many trans persons put English pronouns in their bios while surrounding text is in Chinese (Mandarin). Also, in many languages, pronouns are gender-neutral. {{GENDER:|He|She|They}} in Turkish may be {{GENDER:|o|o|o}}. Users can't guess what it is.

Yes you are right. I didn't consider gender-neutral languages like Turkish where it would be confusing as it is using the same pronouns. I have reverted to the gender symbol implementation in c793959.

Again thank you so much for the PR and the additional insights!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants