Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codemirror position offset on VisualEditor source editing #781

Closed
merqurio opened this issue Feb 3, 2024 · 0 comments
Closed

Codemirror position offset on VisualEditor source editing #781

merqurio opened this issue Feb 3, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@merqurio
Copy link

merqurio commented Feb 3, 2024

Describe the Bug

When editing a page with VisualEditor source editing mode, there is a position offset between text input and renderer elements.

Using the citizen skin as per the CodeMirror configuration, the padding should be 0 to align the content and the CodeMirror editor input. In our installation the CSS seems to not being injected to the browser, leaving an offset between the HTML nodes view by the user and the selection/edition overlay.

Steps to reproduce the behavior:

  1. Go to any page
  2. Click on edit source
  3. Start editing to see the offset
Screenshot 2024-02-03 at 10 20 40

Setting the CSS as per the default config fixes the problem.

.ve-init-mw-desktopArticleTarget .CodeMirror {
    padding: 0!important;
}

Expected Behavior

That the skin CSS CodeMirror configuration is injected by default.

System

Please complete the following information:

  • MediaWiki version 1.41.0
  • Server OS: Debian
  • Installed extensions and versions:
    • Citizen 2.9.0
    • CodeMirror 4.0.0
    • VisualEditor 0.1.2
  • PHP version 8.1.27 (apache2handler)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant