Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Parser and Analyzer support User Defined Function-statements (Moderate) #7953

Closed
3 tasks
kateshaowanjou opened this issue Jun 28, 2022 · 1 comment · Fixed by #8528
Closed
3 tasks

New Parser and Analyzer support User Defined Function-statements (Moderate) #7953

kateshaowanjou opened this issue Jun 28, 2022 · 1 comment · Fixed by #8528
Assignees

Comments

@kateshaowanjou
Copy link
Contributor

Required work and output

  1. Use antlr4 to complete parse statements. The generated statement must follow the original data structure, and should be compatible with the old statement.

  2. In the original syntax file sql_parser.cup, the new syntax needs to be compatible with the syntax of the old version, using the syntax file sql_parser.cup of the old version as the reference standard.

  3. Remove the logic of analytic functions in the statement and move the relevant logic to the new Analyzer framework. The new Analyzer is in the SQL/Analyzer directory.

  4. If the code related to Privilege Check exists in the original analyzer, move the code related to privilege control into PrivilegeChecker.

  5. When submitting the PR, please make sure there is unit test coverage for related changes.

Tasks

  • CreateFunctionStmt
  • DropFunctionStmt
  • ShowFunctionsStmt

How to participate?

  1. Pick an issue you are interested in, click the issue link and leave a comment under the issue to sign up. One person can only choose one issue and the first person who picks the issue will be assigned.

  2. After the issue is assigned, you should complete the task in 14 days. If you are unable to complete it within the specified time, the task will be withdrawn and assigned to others.

  3. Participants are required to produce two pieces of content (forms including but not limited to mind maps, study notes, blogs, and tutorials) in the course of the activity, each of which should be at least 200 words.

  4. Got questions? Join our Slack channel and find channel: #sql-planner.

Before you start

  1. Read Contributing.md carefully to understand how to submit a pull request and how to configure BE and FE development environment.

  2. Sign the Contributor License Agreement before you make a pull request.

  3. To learn more about StarRocks, please refer to StarRocks documentation.

Pull request requirements

  1. Create a pull request (PR) after you complete the task.
  • PR title format: [SR SQL Planner Summer Camp] + PR title
  1. After submitting PR, you can comment under the pinned Issue [SR SQL Planner Summer Camp].
  • Comment format: "I have finished Issue #" + PR link
@huangfeng1993
Copy link
Contributor

Please assign to me, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment