Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3 events #3

Merged
merged 12 commits into from Aug 13, 2021
Merged

M3 events #3

merged 12 commits into from Aug 13, 2021

Conversation

StarSheriff2
Copy link
Owner

Hello Code Reviewer 😸 ,

In this feature branch I wired all the logic to the DOM:

  • Display values in the display
  • Show total in the display when appropriate
  • Use lift state, passing of props to child components, and destructuring in React components
  • Keep code DRY

Copy link

@mricanho mricanho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: ✔️ Project Approved ✔️

Hello @StarSheriff2 🔥

Your app is up and running, super nice job in the modularity of the app, you are using states and props like a pro, nothing more to add here, your app is complete👍🏽

surprised

Now you can merge this branch 🚀

💻 👩🏽‍💻 Happy Coding! 👨🏽‍💻 🖥️


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@StarSheriff2
Copy link
Owner Author

Thank you! :)

@StarSheriff2 StarSheriff2 merged commit 03884d5 into development Aug 13, 2021
@StarSheriff2 StarSheriff2 deleted the m3-events branch August 13, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants