Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedbacks for my portfolio #1

Open
Starboy-Sharma opened this issue Feb 21, 2023 · 7 comments
Open

Feedbacks for my portfolio #1

Starboy-Sharma opened this issue Feb 21, 2023 · 7 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Starboy-Sharma
Copy link
Owner

I want to improve my portfolio and I am looking for suggestions. Please let me know if you feel like something can be changed or improved.

@Starboy-Sharma Starboy-Sharma added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 21, 2023
@pawel975
Copy link

Hello! I think you could customize scrollbar to fit your portfolio colors. For instance track would be less dark then background and thumb would be orange like text. See that topic https://www.w3schools.com/howto/howto_css_custom_scrollbar.asp

Also you can include some animations with gsap so your portfolio would be more interactive.

@manuel12
Copy link
Contributor

Hi :) Overall your portfolio looks really good. Here are some small recommendations:
All issues are on resolution(820x1180 - iPad Air):

  • .about-me text can have the heading "About Me" obscured.

image

  • And on the bottom part of the text is overlapping with the .skills section.

image

  • .project-image and .project-description can be directly in contact with one another, instead of being separated by a little bit of margin, for example.

image

image

That's all I could find.

Hope it helps :)

@Starboy-Sharma
Copy link
Owner Author

Thank you so much for your feedback definitely I will be going to fix all of the issues you have mentioned @manuel12 let me know if you want to make a contribution to my portfolio.

@Starboy-Sharma
Copy link
Owner Author

Hey @pawel975

This is an excellent idea surely I will use a custom scrollbar in my portfolio.

@manuel12
Copy link
Contributor

Thank you so much for your feedback definitely I will be going to fix all of the issues you have mentioned @manuel12 let me know if you want to make a contribution to my portfolio.

Sure :)

I think I have an idea on how to fix the issues that I found. If you want I can commit those fixes and make a pull request. Is that ok with you?

@Starboy-Sharma
Copy link
Owner Author

Thank you so much for your feedback definitely I will be going to fix all of the issues you have mentioned @manuel12 let me know if you want to make a contribution to my portfolio.

Sure :)

I think I have an idea on how to fix the issues that I found. If you want I can commit those fixes and make a pull request. Is that ok with you?

Please go ahead and let me know if you need any help from my side. I have created a new issue where you can create a branch and fix the issues you have mentioned.

Thank you 🧑‍💻

@Starboy-Sharma
Copy link
Owner Author

Hey, 🙋‍♂️ @pawel975 do you want to work on custom scrollbar CSS? If yes then let me know I will assign the #3 to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants