Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events names are confusing and messy #110

Closed
tomalec opened this issue Sep 4, 2018 · 1 comment
Closed

Events names are confusing and messy #110

tomalec opened this issue Sep 4, 2018 · 1 comment

Comments

@tomalec
Copy link
Contributor

tomalec commented Sep 4, 2018

Related to Juicy/imported-template#54, but we have some mess here as well.

To summarize:

  • imported-template dispatches:

    • stamped when HTML Import with partial view is added, before anything is loaded - Should be called somewhat like importing
    • stamping when HTML Import with partial view is being processed
  • starcounter-include dispatches

    • partial-changed, view-model-changed, starcounter-include-composition-saved when composition is saved - those events and functionality should be moved outside of starcounter-include
    • stamped when composition is stamped - should be called, like presentation-stamped
@miyconst
Copy link
Member

Won't be fixed, since the component is not relevant for Starcounter 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants