Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Leprechaun Shoes #456

Closed
TrentXV opened this issue Feb 29, 2020 · 4 comments
Closed

Better Leprechaun Shoes #456

TrentXV opened this issue Feb 29, 2020 · 4 comments
Assignees
Labels
diff: easy A good choice for new modders. No Harmony, easy to figure out or we have good docs/examples. for: smapi status: complete

Comments

@TrentXV
Copy link

TrentXV commented Feb 29, 2020

Make leprechaun shoes increase Luck.

@TrentXV TrentXV added diff: easy A good choice for new modders. No Harmony, easy to figure out or we have good docs/examples. for: smapi labels Feb 29, 2020
@jamespfluger
Copy link

As I am not a contributor I can't add a label, but this should have the needs info label

@TrentXV I don't think would be too hard, but right now "increase Luck" is pretty vague. Are you looking for a small amount or a large ##amount?

If I pick this up then I'll probably add a config file with a customizable value, but I'd have to determine what the default value would be.

The wiki has some insight into daily luck from the fortune teller. The special charm increases it by 0.025 (if I'm reading it correctly), which is a rather small amount.

The temporary food buffs add an excessive amount to use as a default value.

@jamespfluger
Copy link

I'm going to pick this one up. I'll need to use Harmony to change the value of the daily luck, as the luck level itself is used infrequently in comparison. The config file will hold the default value, which will increase the daily luck value by a small amount by default. Likely ~10%

@jamespfluger
Copy link

This is just a release candidate, but I do have a working mod. Daily luck increases by 0.075 by default, which is 3x the amount of the special charm. This can be changed in the config.json file, which contains values for a multiplier and/or added value. It uses Harmony which isn't ideal and the mod could break in future updates, but it is a simple way to implement daily luck changes.

I know Minerva is working this issue as well, and it sounds like it'll be a better solution that mine because it won't be using Harmony (unlike mine). Minerva and someone else started work before me, so I won't be continuing my immediate development. However, I did want want to publish my work for anyone trying to learn how luck can be modified or consider a different approach than what they have so far.

I won't be releasing this on Nexus, nor anywhere else, unless nobody else ends up releasing a mod for this.

@minervamaga
Copy link

@minervamaga minervamaga added status: complete and removed diff: easy A good choice for new modders. No Harmony, easy to figure out or we have good docs/examples. status: in progress labels Mar 12, 2020
@Pathoschild Pathoschild added the diff: easy A good choice for new modders. No Harmony, easy to figure out or we have good docs/examples. label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff: easy A good choice for new modders. No Harmony, easy to figure out or we have good docs/examples. for: smapi status: complete
Projects
None yet
Development

No branches or pull requests

4 participants