Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue in SFCP component fix #657

Closed
Constellation-VASCO opened this issue Nov 20, 2023 · 2 comments
Closed

Issue in SFCP component fix #657

Constellation-VASCO opened this issue Nov 20, 2023 · 2 comments
Labels
Fix Ready A fix for this issue is ready for merging and testing Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Items Relates to items e.g. weapons, food, clothing

Comments

@Constellation-VASCO
Copy link
Collaborator

I routinely check the changes of the SFCP via SFEdit for conflicts with other mods. Is it possible you made a mistake on the fix for "Red Harvest Double Malt Whiskey" [ALCH:0003614B] - instead of ResGastroLiquor "Liquor" [IRES:0029B02D] like for the Single Malt, SFEdit shows me ResGastroCoffee "Coffee" [IRES:0029B017] as the component. However, I don't think Double-Malt is made from Coffee :-).

Details

Concerns the fix of SFCP to "Red Harvest Double Malt Whiskey" [ALCH:0003614B]
Patched component in 0.0.4 is "Coffee" [IRES:0029B017].
However, it should be "Liquor" [IRES:0029B02D] like for the Single Malt.

Game Version

1.7.36.0

Language

English (EN)

New Game

No

Reproduction Steps

Run SFEdit and open the respective component in SFCP 0.0.4 and inspect it.
@Constellation-VASCO Constellation-VASCO added Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Items Relates to items e.g. weapons, food, clothing labels Nov 20, 2023
@Constellation-VASCO
Copy link
Collaborator Author

Can confirm the issue in 0.0.4. The plugin I posted to Nexus in the original bug report still has the correct components set.

@TESWartortle
Copy link

Issue 657.zip

Still present in 0.0.6. One month after being reported. Smh. Here's the fix.

@Pickysaurus Pickysaurus added the Fix Ready A fix for this issue is ready for merging and testing label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fix Ready A fix for this issue is ready for merging and testing Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Items Relates to items e.g. weapons, food, clothing
Projects
Main Project
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Pickysaurus @TESWartortle @Constellation-VASCO