Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect use of the IsWeaponOut condition #866

Closed
Constellation-VASCO opened this issue Feb 9, 2024 · 1 comment
Closed

Incorrect use of the IsWeaponOut condition #866

Constellation-VASCO opened this issue Feb 9, 2024 · 1 comment
Labels
Fix Ready A fix for this issue is ready for merging and testing Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Missions & Dialogue Relates to missions (quests), NPC dialogue or player dialogue options

Comments

@Constellation-VASCO
Copy link
Collaborator

Security guards never comment on the player's unholstered weapon due to incorrect use of the IsWeaponOut condition.


Details

The function IsWeaponOut returns the following values:

  • 0 - If the Actor does not have a weapon drawn.
  • 1 - If the Actor has only his fists out.
  • 2 - If the Actor has a weapon.

Security guards should comment on the player's unholstered weapon (e.g., "Want to put that weapon away? You're making me nervous."). However, in these dialogs, the game checks for IsWeaponOut=1, not for IsWeaponOut=2. Because of that, these lines never trigger.


Affected lines

  • 0006175C
  • 0006175D
  • 0006175E
  • 000447DA
  • 000447DB
  • 00217853
  • 00219AF1
  • 001569C9
  • 0015DA46
  • 0015DA47

How to fix

  • Quest \ 00061754 \ 00061757 \ 0006175C - "Gonna need you to holster that weapon."
  • Quest \ 00061754 \ 00061757 \ 0006175D - "Hey, no weapons. Put that away."
  • Quest \ 002BCA5E \ 0015DA4D \ 001569C9 - "Whoa whoa. Any reason you can't holster that?"

  • Quest \ 00061754 \ 00061757 \ 0006175E - "Better not start any trouble."

This phrase can be said for both weapons AND fists.

  • Quest \ 0023FB04 <UC_TerrormorphSupportQuest> \ 0023FAF9 \ 000447DA - "Put down your weapons. We just want to be friends."
  • Quest \ 0023FB04 <UC_TerrormorphSupportQuest> \ 0023FAF9 \ 000447DB - "You! Put it down! Put down the weapon or we shoot!"

  • Quest \ 0026D87F <MQ105_AlwaysOnDialogueNeon> \ 0026D87E \ 00217853 - "Hey, keep the weapon holstered, will you?"
  • Quest \ 002BCA5E \ 0015DA4D \ 0015DA46 - "Want to put that weapon away? You're making me nervous."
  • Quest \ 002BCA5E \ 0015DA4D \ 0015DA47 - "Want to put that weapon away, chief? You're making me nervous."

  • Quest \ 002A0E95 <UC05_EmbassySupportQuest> \ 001DC55F \ 00219AF1 - "Stash the weapon. You're in an embassy, for goodness' sake."

Game Version

1.9.51.0

Language

English (EN)

New Game

Yes

Reproduction Steps

  1. Unholster your weapon.
  2. Try to talk to any common guard in New Atlantis (or other cities) as many times as you can.
  3. Notice that guards never comment on your weapon.
@Constellation-VASCO Constellation-VASCO added Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Missions & Dialogue Relates to missions (quests), NPC dialogue or player dialogue options labels Feb 9, 2024
@Constellation-VASCO
Copy link
Collaborator Author

@Pickysaurus Pickysaurus added the Fix Ready A fix for this issue is ready for merging and testing label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Ready A fix for this issue is ready for merging and testing Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Missions & Dialogue Relates to missions (quests), NPC dialogue or player dialogue options
Projects
Status: Closed
Development

No branches or pull requests

2 participants