Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guards say "Evening" regardless of the time of day #879

Closed
Constellation-VASCO opened this issue Feb 24, 2024 · 1 comment
Closed

Guards say "Evening" regardless of the time of day #879

Constellation-VASCO opened this issue Feb 24, 2024 · 1 comment
Labels
Fix Ready A fix for this issue is ready for merging and testing Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Missions & Dialogue Relates to missions (quests), NPC dialogue or player dialogue options

Comments

@Constellation-VASCO
Copy link
Collaborator

Security guards say "Evening, sir/ma'am." no matter what time of day it is. They should say this line only in the evening.


Details

Affected IDs:

  • 0015DA43
  • 0015DA44
  • 0015DA45

I haven't found an easy way to get the local time (GetCurrentTime returns UT, which is useless for this case). However, there are a few time-related functions we could use:

  • IsTimeSpanSunrise: 06:00-08:59
  • IsTimeSpanMorning: 9:00-11:59
  • IsTimeSpanAfternoon: 12:00-15:59
  • IsTimeSpanEvening: 16:00-17:59
  • IsTimeSpanSunset: 18:00-20:59
  • IsTimeSpanNight: 21:00-05:59
  • IsTimeSpanMidnight: 00:00-05:59

I added some of these as conditions to ensure the lines are only said from 18:00 to 23:59 local time:

Game Version

1.9.67.0

Language

English (EN)

New Game

Yes

Reproduction Steps

  1. Go to New Atlantis (or any other city) at any time of day except evening.
  2. Try to talk to any generic guard as many times as you can.
  3. Notice that guards sometimes mention evening.
@Constellation-VASCO Constellation-VASCO added Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Missions & Dialogue Relates to missions (quests), NPC dialogue or player dialogue options labels Feb 24, 2024
@Constellation-VASCO
Copy link
Collaborator Author

@TERAB1T TERAB1T added the Fix Ready A fix for this issue is ready for merging and testing label Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Ready A fix for this issue is ready for merging and testing Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Missions & Dialogue Relates to missions (quests), NPC dialogue or player dialogue options
Projects
Status: Closed
Development

No branches or pull requests

2 participants