Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breyson Bayu Companion Response Dialogue Incorrect Conditions #888

Closed
Aurelianis opened this issue Feb 29, 2024 · 1 comment
Closed

Breyson Bayu Companion Response Dialogue Incorrect Conditions #888

Aurelianis opened this issue Feb 29, 2024 · 1 comment
Labels
Fix Ready A fix for this issue is ready for merging and testing Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Missions & Dialogue Relates to missions (quests), NPC dialogue or player dialogue options

Comments

@Aurelianis
Copy link
Member

Aurelianis commented Feb 29, 2024 •
edited by github-actions bot

When speaking to Breyson during Absolute Power, he has dialogue to respond to companions but the conditions are incorrect so they never fire.

Details

All INFOs under [DIAL:0018238B]
00182384
00182385
00182386
00182387

Conditions for GetDistance are set incorrectly and should be:
QuestAlias.GetDistance(PlayerRef [PLYR:00000014]) <= COM_InterjectionDistance [GLOB:0000D8A9]

For 00182386, both conditions are incorrect. The conditions should be:
QuestAlias.GetIsVoiceType(NPCMBarrett [VTYP:00005B85]) = 1 AND
QuestAlias.GetDistance(PlayerRef [PLYR:00000014]) <= COM_InterjectionDistance [GLOB:0000D8A9]

Fix Attached:
BreysonBayuReponseFixCF06.zip

Game Version

1.9.67

Language

English (EN)

Have you recreated this issue on a new game?

Yes, I can recreate this issue.

Reproduction Steps

During Absolute Power, talk to Breyson. Choose "I agree, he deserves everything coming to him." Breyson then talks about Benjamin Bayu talking about him behind his back. This is where a companion will chime in and Breyson is suppose to respond to them, but the conditions are incorrect so the dialogue doesn't fire.
@github-actions github-actions bot added Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Missions & Dialogue Relates to missions (quests), NPC dialogue or player dialogue options labels Feb 29, 2024
@Aurelianis Aurelianis changed the title Breyson Bayu Companion Response Dialogue Incorrect Condtiions Breyson Bayu Companion Response Dialogue Incorrect Conditions Feb 29, 2024
@Aurelianis Aurelianis added the Fix Ready A fix for this issue is ready for merging and testing label Feb 29, 2024
@Constellation-VASCO
Copy link
Collaborator

The ESM provided seems to forward the records without actually changing them. I've manually applied the fix based on your notes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fix Ready A fix for this issue is ready for merging and testing Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Missions & Dialogue Relates to missions (quests), NPC dialogue or player dialogue options
Projects
Main Project
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Aurelianis @Constellation-VASCO