Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot fold code #13

Closed
GammaGames opened this issue Oct 1, 2018 · 6 comments
Closed

Cannot fold code #13

GammaGames opened this issue Oct 1, 2018 · 6 comments
Assignees

Comments

@GammaGames
Copy link

GammaGames commented Oct 1, 2018

One of the recent updates broke the folding

peek 2018-10-01 10-40

@macjuul macjuul self-assigned this Oct 1, 2018
@macjuul
Copy link
Member

macjuul commented Oct 1, 2018

Hey Gamma, ive been trying to reproduce this bug with some other people and it seems to happen for about half of them (excluding me). I'll be looking into a fix for this issue, however it would be great if you could share some more setup details (e.g. operating system, extension version, CA settings, etc.) and see if this happens in other files as well.

Thanks again!

@Densorius
Copy link

Hello there,

With some quick testing, typescript and JavaScript files don't have the bug. But when I change the file type to C#, PHP or java the bug appears.

Also, when I change the file type from for example java to JavaScript the bug persists until I make a change after which the bug disappears.

@macjuul
Copy link
Member

macjuul commented Oct 3, 2018

After some more testing I can conclude folding is absolutely buggered in both C# and Java, works flawlessly in JavaScript and TypeScript, but only works in Python without Comment Anchors. Since I'm doing nothing out of the ordinary (simply registering one fold provider) this can only be an issue related to the specific language extensions or VS Code itself.

Since I'm unable to solve this issue, I'll instead implement a setting to disable folding instead.

Hopefully this will still resolve your issues!

@GammaGames
Copy link
Author

That's really weird! I wonder if it's an issue with vsc and if it should be reported. I don't really need anchor folding, so a setting would work well for me. Thank you!

@macjuul
Copy link
Member

macjuul commented Oct 4, 2018

Alright, the setting will be available in the next release. I've tested it with python and can confirm it fixes language folding

@macjuul macjuul closed this as completed Oct 4, 2018
@GammaGames
Copy link
Author

Seems to be working great, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants