Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Experimental "Entity-Like" Built-in Resource Pack #115

Open
2 tasks
StartsMercury opened this issue Oct 29, 2023 · 2 comments
Open
2 tasks

Split Experimental "Entity-Like" Built-in Resource Pack #115

StartsMercury opened this issue Oct 29, 2023 · 2 comments
Labels
enhancement New feature or request medium priority Needs attention need more info Further information is requested

Comments

@StartsMercury
Copy link
Owner

@StartsMercury StartsMercury added enhancement New feature or request medium priority Needs attention need more info Further information is requested labels Oct 29, 2023
@CocoManiaDX
Copy link

Hello! Just wondering if it's possible to modify the built in resource pack to still disable the shading of entities in-world, but still keep the shading for the blocks on the GUI?

Mostly cause some items become very hard to see on the GUI without shading. Things like stone, andesite and whatnot.

Regardless, thanks a lot for the work you're putting into this <3

@StartsMercury
Copy link
Owner Author

StartsMercury commented Mar 31, 2024

It was thanks to Minecrafthyr that we now have experimental entity(-like) shading from issue #113 .

The built-in resource pack isn't really doing anything complicated. So what it does, it overwrites that one Minecraft include shader code, specifically the minecraft_mix_light() function in include/light.glsl, which is used everywhere, and thus why it affects all sorts of things such as models drawn on interfaces. The core shader(s) that actually handles entity shading could be identified (or just find the ones that calls the said shared shader code) and add specific checks to filter for entities (maybe the one mentioned in https://github.com/McTsts/Minecraft-Shaders-Wiki/blob/main/Isolating%20Items.md).

It can be done, though why it's not yet in the mod is that it needs to somewhat not needlessly affect other code and I'm not sure if it's possible to do in resource packs. So, I was planning to achieve this by modifying or transforming (https://github.com/IrisShaders/glsl-transformer) loaded shaders and add the needed modifications there.

Edit: Also I apologize if I got something wrong about core shaders, I am not an expert :')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium priority Needs attention need more info Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants