Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things that are unpolished or TODOs #21

Closed
bmanbzan opened this issue May 22, 2020 · 17 comments
Closed

Things that are unpolished or TODOs #21

bmanbzan opened this issue May 22, 2020 · 17 comments

Comments

@bmanbzan
Copy link
Contributor

Let's get a simple list going on anything we know that still needs to be tweaked, but works well enough to user test during the hackathon next week.

@bmanbzan
Copy link
Contributor Author

When namespace request fails:

open the modal on redirect
OR
(if possible, I imagine it needs AJAX) show the error in the modal without navigating away

@bmanbzan
Copy link
Contributor Author

When namespace request sent:

navigate back down to the section on redirect
(almost like they didn't redirect after all)

@bmanbzan
Copy link
Contributor Author

Username and email are not editable in the account modal

@bmanbzan bmanbzan changed the title Known issues / TODO during hackathon Unpolished or TODO during hackathon next week May 22, 2020
@bmanbzan
Copy link
Contributor Author

bmanbzan commented May 22, 2020

Add-on options ("request a namespace" and "add a dashboard") are uni-lingual in the code and need to be broken out into the locale.

DONE

@bmanbzan
Copy link
Contributor Author

Google Translate will be used for the French until the text comes back from Translation Services.

(Everyone feel free to highlight obvious errors and suggest fixes)

@bmanbzan
Copy link
Contributor Author

No spam protection on feedback or namespace features.

Add captcha v3 to protect them and not burden the user.

@bmanbzan bmanbzan changed the title Unpolished or TODO during hackathon next week Things that are unpolished or TODOs May 22, 2020
@StatCan StatCan deleted a comment from M-A-Boucher May 22, 2020
@bmanbzan
Copy link
Contributor Author

Apply the new hover effect (colour and upwards movement) to the other primary buttons:

  • LOG IN (in hero)
  • Top-right buttons
  • "More virtual labs"
  • anything else I missed

@bmanbzan
Copy link
Contributor Author

Language toggle works fine the first click or so, then you have to click it twice to actually change. Sometimes the page changes but the button label doesn't.

@bmanbzan
Copy link
Contributor Author

bmanbzan commented May 23, 2020

Safari iPad hero almost fits... the FIP is cut off slightly

Bottom FIP sig is slightly cut off too

@bmanbzan
Copy link
Contributor Author

Change the "Email" input on ExternalLoginCallback to an "email" input so mobile browsers use the special keyboard.

@bmanbzan
Copy link
Contributor Author

Chrome iPad her FIP is completely cut off. (not a huge deal)

Bottom FIP sig is slightly cut off too.

@bmanbzan
Copy link
Contributor Author

bmanbzan commented May 23, 2020

Firefox Focus mobile hides the feedback modal when the bottom link is tapped.

The modal displays but when the text area gets focus and the keyboard comes up, it scrolls away.

The top link didn't do that though... strange!

@bmanbzan
Copy link
Contributor Author

Firefox Focus mobile hides the namespace modal when the input has focus and the keyboard comes up.

(like the issue above with the feedback modal)

@M-A-Boucher
Copy link
Contributor

Change the "Email" input on ExternalLoginCallback to an "email" input so mobile browsers use the special keyboard.

Done.

@M-A-Boucher
Copy link
Contributor

Apply the new hover effect (colour and upwards movement) to the other primary buttons:

  • LOG IN (in hero)
  • Top-right buttons
  • "More virtual labs"
  • anything else I missed

Done. Button contrast changes will be a separate issue.

@bmanbzan
Copy link
Contributor Author

bmanbzan commented Jun 3, 2020

When namespace request sent:

navigate back down to the section on redirect
(almost like they didn't redirect after all)

No new issue will be created for this because it will be taken care of in #33

@bmanbzan
Copy link
Contributor Author

bmanbzan commented Jun 3, 2020

Finished items have the 👍

Items moved to their own ticket have the 🚀

@bmanbzan bmanbzan closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants