Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add error catching for s3-pull batchInsert #2236

Open
crayolakat opened this issue Nov 8, 2022 · 0 comments · May be fixed by #2250
Open

Feature Request: Add error catching for s3-pull batchInsert #2236

crayolakat opened this issue Nov 8, 2022 · 0 comments · May be fixed by #2250
Labels
C-enhancement Type: enhancement

Comments

@crayolakat
Copy link
Collaborator

Problem
We have experienced issues with the batchInsert function in the s3-pull contact loader failing due to data format issues. There is no logging to catch errors for this batchInsert function and therefore made it difficult to identify and troubleshoot.

Solution
Add error catching for the batchInsert function.

Context
Relevant line of code: https://github.com/MoveOnOrg/Spoke/blob/2e8c479ef7e4071bc903bdf882334488b50f2910/src/extensions/contact-loaders/s3-pull/index.js#L190

Relevant knex documentation on how to add error catching: https://knexjs.org/guide/utility.html

@crayolakat crayolakat added the C-enhancement Type: enhancement label Nov 8, 2022
@crayolakat crayolakat changed the title Feature Request: await r.knex.batchInsert("campaign_contact", insertRows); Feature Request: Add error catching for s3-pull batchInsert Nov 8, 2022
@crayolakat crayolakat linked a pull request Dec 16, 2022 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Type: enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant