Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sendMessage speed #6

Closed
3 tasks done
shakalee14 opened this issue May 22, 2017 · 2 comments
Closed
3 tasks done

Improve sendMessage speed #6

shakalee14 opened this issue May 22, 2017 · 2 comments
Assignees
Labels
C-bug Type: Bug
Projects

Comments

@shakalee14
Copy link
Contributor

shakalee14 commented May 22, 2017

  • Assign contact number upon signup instead of on first text
  • Move more of the method of sendMessage into the async part of sendMessage. See if we can get it down to < 50ms.
  • Make it threadsafe so we can have multiple message senders. Possibly look into using my new job queue to do this, creating a queue per number.
@shakalee14 shakalee14 added the C-bug Type: Bug label Jun 8, 2017
@shakalee14
Copy link
Contributor Author

Believe this also could be a server issue

@shakalee14 shakalee14 added this to Hackathon Issues in Spoke Jun 15, 2017
@shakalee14 shakalee14 added the p1 label Jun 15, 2017
@sreynen
Copy link
Contributor

sreynen commented Jul 25, 2017

From chat, my understanding is the key thing we're trying to speed up here is the interface of sending messages, not the actual delivery speed. I attempted to time how long the interface takes to move from sending to the next contact and found it at least feels instance. I'm not 100% it's <50ms, but only because 50ms turns out to be faster than I can hit "stop" on a timer.

We already have multiple message sender workers, each running as a separate process, which I believe is as threadsafe as nodeJS can be.

So I think this issue may be resolved, and if it's not, I would like more context on what we want to speed up.

@sreynen sreynen self-assigned this Jul 25, 2017
bchrobot referenced this issue in bchrobot/Spoke Jun 14, 2018
refined query, wired in data from new query with data grid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Type: Bug
Projects
No open projects
Spoke
Hackathon Issues
Development

No branches or pull requests

2 participants