-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smspec c++ #538
Merged
Merged
Smspec c++ #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
582e793
to
cbb20d9
Compare
This was referenced Nov 25, 2018
d54c6c7
to
6daee23
Compare
smsped_node: added constructor for class. smspec_node constructor: resolved main issues. smspec_node_init__ class function. smspec_node: set_num is a member function. ... smspec_node: wgname. smspec_node: decodeR1R2 as member function. smspec_node: constructor functions v/ statics as member functions. ... smspec_node: cmp function as member function. smspec_node: all member functions converted to class members. smspec _node: wgname made private. smspec_node: all parameters are private. ...
756d370
to
c123416
Compare
joakim-hove
commented
Nov 27, 2018
@@ -23,28 +23,13 @@ | |||
#include <ert/ecl/ecl_sum.hpp> | |||
#include <ert/ecl/ecl_smspec.hpp> | |||
|
|||
void test_sort( ecl_smspec_type * smspec ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this test is removed because the whole ecl_smspec_sort()
functionality is removed.
c1eeec0
to
6326113
Compare
Closed
b13d75a
to
eb6543d
Compare
…resample, new short summary case.
Fix to add_node issue, copy smspec_node constructor, args to summary_…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #526
equinor/libres#458
equinor/ert#167
Note: An important lesson learned while working with this task was the following:
In the old C code a quite common pattern was the following:
This has worked reasonably well - when switching to C++ it was intially tempting to install value objects in a
std::vector<my_class>
instance, and then access pointers to those from astd::map<my_class *>
- that does not work. The point is that when thestd::vector<my_class>
manages the instances they will not be in stable memory, and things fall apart. This pattern is quite common in librecl/libres!