New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GDevelop as Engine #54
Conversation
@@ -53,6 +53,8 @@ CryEngine[] = (?:^|/)engine\.pak$ | |||
CryEngine[] = \.cry$ | |||
Defold = (?:^|/)game\.dmanifest$ | |||
FNA = (?:^|/)fna\.dll$ | |||
GDevelop[] = (?:^|/)gd\.js$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This detects /node_modules/moment/locale/gd.js
And some of the games you linked don't have any |
Can you list the games that don't have these files? |
First two links.
It is possible by writing custom logic in the php file, but it is preferable to avoid that. |
Thanks! I've not checked the second game but seems it's not on the Steam store anymore (replaced by the author by a not yet released full version, while this was a demo).
Fair enough, I can suggest |
There are no depots that have a |
Thanks for checking, I was assuming Electron would not package files by default - my mistake. Seems like there is no obvious way then to check for the engine. I'll see if we can make this obvious with a specific file in a future version then. |
SteamDB app page links to a few games using this
https://steamdb.info/app/1307760/
https://steamdb.info/app/1622620/
https://steamdb.info/app/842170/
https://steamdb.info/app/1460910/
https://steamdb.info/app/1342220/
Brief explanation of the change
Hi 馃憢
This adds rules for detecting GDevelop (both for GDevelop 5 and GDevelop 4).