You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Launching PboViewer via command line using a path to a mission folder as argument is bugged. This is a twofold issue:
when the mission folder path doesn't end with a slash, PboViewer opens with an empty GUI, seemingly ignoring the folder path argument (minor nuisance, but not catastrophic)
when the mission folder path ends with a slash, PboViewer opens the folder properly, but exporting the folder yields a broken .pbo file (missing files/folders, and the first character is trimmed). PboViewer is effectively unuseable when launched this way.
To Reproduce
Steps to reproduce the behavior: 1. Download the attached test mission archive and extract it somewhere (in this example, next to PboViewer) 2. Start your terminal and launch PboViewer with the folder path as argument:
./PboViewer "Test.Altis"
3. Observe that PboViewer starts with an empty GUI: 4. Close PboViewer 5. In the terminal, launch PboViewer with the same folder path as argument, but add a trailing slash at the end:
./PboViewer "Test.Altis/"
Observe that PboViewer now opens the folder in the GUI: 6. Click "Pack the folder to PBO" 7. Notice that the file name field is empty (it isn't when manually opening a folder in PboViewer and packing to PBO) 8. Enter a name and hit "Save" 9. Close PboViewer 10. Open the exported mission PBO file with PboViewer (not necessarily using the command line this time, though it shouldn't make a difference) 11. Notice that the PBO contains files with incorrect names (first character is trimmed), and contains garbled data (some files are empty, others contain binary data, yet all files were originally text files)
Expected behavior
Trailing slashes, or the absence thereof, should not have an impact on the behaviour of the program (consistency)
PboViewer should suggest the name of the opened folder when exporting to a PBO
Exporting to a PBO shouldn't break files (obviously 😛)
Hello, sorry for the long reply, that is an interesting bug. I will check on my side. I suspect it comes from the PBO library implementation. I will check that asap.
Describe the bug
Launching PboViewer via command line using a path to a mission folder as argument is bugged. This is a twofold issue:
To Reproduce
Steps to reproduce the behavior:
1. Download the attached test mission archive and extract it somewhere (in this example, next to PboViewer)
2. Start your terminal and launch PboViewer with the folder path as argument:
./PboViewer "Test.Altis"
3. Observe that PboViewer starts with an empty GUI:
![image](https://private-user-images.githubusercontent.com/3143797/346898349-73d594ec-f31c-4247-8d36-768f59d8f3b4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEwNjg5MDksIm5iZiI6MTcyMTA2ODYwOSwicGF0aCI6Ii8zMTQzNzk3LzM0Njg5ODM0OS03M2Q1OTRlYy1mMzFjLTQyNDctOGQzNi03NjhmNTlkOGYzYjQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTVUMTgzNjQ5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTFkMmVjMjY5OGYzODZjMzVmM2QyYTJjNjRiYjEyNjUzOTYwMjBjZTk0ZmQwOGQwMzA4YzYzN2M2OWVjYzc0NCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.twzyTPzG8xRXex9oocN_-xFDaqYhkz0ermpcMT_Dbf8)
4. Close PboViewer
5. In the terminal, launch PboViewer with the same folder path as argument, but add a trailing slash at the end:
./PboViewer "Test.Altis/"
Observe that PboViewer now opens the folder in the GUI:
![image](https://private-user-images.githubusercontent.com/3143797/346898810-47115f6e-b0fb-4f8a-864c-dd61dace80c7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEwNjg5MDksIm5iZiI6MTcyMTA2ODYwOSwicGF0aCI6Ii8zMTQzNzk3LzM0Njg5ODgxMC00NzExNWY2ZS1iMGZiLTRmOGEtODY0Yy1kZDYxZGFjZTgwYzcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTVUMTgzNjQ5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODk1YjUwNDgzMjNhZGEyZDgxOTNkNzYxNDhkYmI2ZTU0OGM0OTNlNmJkNzQ0NDhlMDIyMGNiMDU0N2ZiNjdhOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.gHsTF5riuKMOrT7QgElbpvrqqGVrdZjqeGwHDg1c9to)
![image](https://private-user-images.githubusercontent.com/3143797/346897396-215176fe-3324-4d6f-9248-6f6848f14e27.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEwNjg5MDksIm5iZiI6MTcyMTA2ODYwOSwicGF0aCI6Ii8zMTQzNzk3LzM0Njg5NzM5Ni0yMTUxNzZmZS0zMzI0LTRkNmYtOTI0OC02ZjY4NDhmMTRlMjcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTVUMTgzNjQ5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmRlM2FkNTU5OGU4ZjMwYWUzMTA5MDI3ZTdjOTlkNTAzNmM4NjI1MmE2MmQ0ZTViNGE0NGI3OTU2MjkxZDU5OSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.LsgSQeGpLk0X2avoKgpMdT0XJOIHfdcW9vNTe60sIkA)
6. Click "Pack the folder to PBO"
7. Notice that the file name field is empty (it isn't when manually opening a folder in PboViewer and packing to PBO)
8. Enter a name and hit "Save"
9. Close PboViewer
10. Open the exported mission PBO file with PboViewer (not necessarily using the command line this time, though it shouldn't make a difference)
11. Notice that the PBO contains files with incorrect names (first character is trimmed), and contains garbled data (some files are empty, others contain binary data, yet all files were originally text files)
Expected behavior
Screenshots
![image](https://private-user-images.githubusercontent.com/3143797/346900978-eb1e71aa-8fc0-4aad-b60b-cfd8fbd2fdd9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEwNjg5MDksIm5iZiI6MTcyMTA2ODYwOSwicGF0aCI6Ii8zMTQzNzk3LzM0NjkwMDk3OC1lYjFlNzFhYS04ZmMwLTRhYWQtYjYwYi1jZmQ4ZmJkMmZkZDkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTVUMTgzNjQ5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YmI0ZDIyODcyNjQ3ZDNmMGRiNDhkYzkzNTk2MjRiOWM0YzFiM2VjMTFhOGJmMGI5NmUxYTMxMDNmYTJhZDE3ZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.SUGg108Biqj499p8liGeuA1dcA8PsMBZD_kd-f6Ymyc)
Overview of the test mission folder:
Operating system
Arch Linux 6.9.8-arch1-1
Additional context
Test mission archive:
Test.Altis.tar.gz
Exported PBO file (renamed to
.zip
to allow uploading):Test.Altis.pbo.zip
The text was updated successfully, but these errors were encountered: