Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview release of dll #94

Closed
jwikman opened this issue Nov 16, 2021 · 11 comments
Closed

Preview release of dll #94

jwikman opened this issue Nov 16, 2021 · 11 comments

Comments

@jwikman
Copy link
Contributor

jwikman commented Nov 16, 2021

The auto deployment of the Linter Cop DLL is really neat!

But when deploying fixes it might be a bit to easy to deploy a fix with regression issues or that a new rule that is not yet 100% perfect creates zillions of new warnings that will just confuse users until they understand the rule completely.

So I suggest that a new boolean setting is added to the VSCode extension, Install Preview releases, or similar.
If this setting is active, the dll should be downloaded from another location - to where you deploy preview versions of the dll.

In that way you can get things tested out by a group of volunteers and get feedback before deploying to all users.

I would always have the preview release installed... 😉

Thoughts?

@rvanbekkum
Copy link
Contributor

That would be really nice. When there are errors/false positives in these code analyzers, then it becomes very difficult to distinguish real warnings from errors and makes the LinterCop inoperable.
Would be nice to have preview versions for which we could provide you (and others) with feedback. 😊

@StefanMaron
Copy link
Owner

100%
But to prepare for this, I will need to implement a branching strategy and need to adjust the pipeline.

Another thought I had, was to introduce new rules as info or even as disabled first.
Testers can activate the rule via ruleset and report any issues.
That would work with less overhead and preparation.

@jwikman
Copy link
Contributor Author

jwikman commented Nov 16, 2021

I would vote for a new branching strategy with a "preview" branch.

The other approach would work on new rules, but for changes in existing rules you would still risk to mess with a lot of users if a bug sneaks in.

I believe that the majority of developers would value stable and correct (now what that is 😉) code cop rules higher than smoking new changes and additions.

But for some people, as myself, like to work with new things and want to help to make our developer experience the best it can be - and for those, some kind of "preview" feature would be great.

@StefanMaron
Copy link
Owner

I will think about how to change branching strategy and pipeline, as well as a possibility to get auto update for preview releases 👍

@jwikman
Copy link
Contributor Author

jwikman commented Nov 16, 2021

Super!
Just let me know if you need help brainstorming about that or if I should test something out.

@StefanMaron
Copy link
Owner

I made changes to the pipeline, branches and to the vs code extension.

add "linterCop.load-pre-releases": true to the settings and you will get the pre-releases automatically 💪

@jwikman
Copy link
Contributor Author

jwikman commented Nov 26, 2021

Cool @StefanMaron !

I just updated the extension and configured this - but how do I know if it works? 😉

I didn't see any new "Downloaded BC DLL" dialogue, not even after restart. And if I execute "BC: Download Linter cop" nothing happens either (from what I can see at least)

@StefanMaron
Copy link
Owner

Normally a dialog should show up. You can check the version of the dll in the file details.
I will think about a better way, maybe an indicator somewhere to show the current file version

@jwikman
Copy link
Contributor Author

jwikman commented Nov 26, 2021

I got dll v0.21.9.0 - Where do I find the current release and prerelease version in the repo?

@StefanMaron
Copy link
Owner

You will get an overview of all releases by clicking here on Releases:
image

@jwikman
Copy link
Contributor Author

jwikman commented Nov 26, 2021

Ofcourse, where else! 😀

Well done!

Case closed, have a beer and a super weekend!

@jwikman jwikman closed this as completed Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants