Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring on using RestClient instead of RestTemplate #138

Open
StefanSchubert opened this issue Aug 6, 2023 · 3 comments
Open

Refactoring on using RestClient instead of RestTemplate #138

StefanSchubert opened this issue Aug 6, 2023 · 3 comments
Labels
good first issue Light Task to get into the project help wanted

Comments

@StefanSchubert
Copy link
Owner

StefanSchubert commented Aug 6, 2023

According to spring documentation RestTemplate is in maintenance only mode. I suppose it will be marked as deprecated sooner or later. ( Check "NOTE" in its documentation: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/web/client/RestTemplate.html )

Meanwhile the Project is on SpringBoot3.2 which brings in the RestClient as an alternative to the WebClient.
See https://youtu.be/UDNrJAvKc0k

Which seems the appropriate successor. It comes with a fluent API and offers more flexibility through the extensibility by adding Interceptors as well.

@StefanSchubert StefanSchubert added help wanted good first issue Light Task to get into the project labels Aug 6, 2023
@AKARSHITJOSHI
Copy link

Hi @StefanSchubert I would like to contribute on this. Let me know where to get started.

@StefanSchubert
Copy link
Owner Author

Hi @AKARSHITJOSHI,

thanks for reaching out. You are the first contributor here, so your first step would be to do the review on setting up the software development environment. ;-) For doing so, you need to follow the section: "Setting up the development environment" from the main README.md of the repository. Let me know if you stuck somewhere.

Have also a look onto the contribution.md guide.

Once the local setup was successful you have the modules available for testing, see section 3.2 from https://github.com/StefanSchubert/sabi/wiki/03.-System-Scope-and-Context

for the task you require to draw your attention towards the frontend module (sabi-webclient) first. The package de.bluewhale.sabi.webclient.apigateway containts the RestTemplate communication which needs to be replaced accordingly. There are currently no junits on the frontend module, so you need to do an explorative testing locally.

Once this task is finished, the attention should go to the backend module, which uses restTeamplate to communicate with the captcha module and there are some junits to demonstrate the api usage which are also based on the resttemplate.

By the way, do you have a fish tank? Or are you just technically interested (which is also fine :-) )

@StefanSchubert
Copy link
Owner Author

Hi @AKARSHITJOSHI,
as I haven't heard anything from you since then. I'm going to rewrite the Issue as meanwhile we are on SpringBoot3.2 and this brought us the new RestClient which is a better solution for this purpose.
Let me know if you still have interest and time to contribute.

@StefanSchubert StefanSchubert changed the title Refactoring on using WebClient instead of RestTemplate Refactoring on using RestClient instead of RestTemplate Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Light Task to get into the project help wanted
Projects
None yet
Development

No branches or pull requests

2 participants